Switch to the I-beam cursor when hovering over the terminal #5028

DHowett-MSFT · 2020-03-20T03:29:55Z

This commit makes us use the I-beam cursor when the user hovers over the
terminal, unless mouse mode is enabled. I've also plumbed up a bunch
of events so that:

If mouse mode is toggled while hovering, the cursor will switch to
the arrow if it's on or the I-beam if it's off.
If you hold down shift to suppress mouse mode, the cursor will switch
back to the I-beam.

Fixes #1441.

Detailed Description of the Pull Request / Additional comments

It turns out that we're in violation of the Windows human interface guidelines, so that's good.

It also turns out that you cannot set the cursor type of a control -- you actually have to actively set and reset the cursor when the pointer enters or exits.

my selection color is bright red to differentiate it from vim's mouse mode selection

This commit makes us use the I-beam cursor when the user hovers over the terminal, *unless* mouse mode is enabled. I've also plumbed up a bunch of events so that: * If mouse mode is _toggled_ while hovering, the cursor will switch to the arrow if it's on or the I-beam if it's off. * If you hold down shift to suppress mouse mode, the cursor will switch back to the I-beam. Fixes #1441.

zadjii-msft · 2020-03-20T22:58:59Z

On a scale of yes to no, could this be made a setting (in a future PR) so I could disable this? Should it be a global or a profile setting?

DHowett-MSFT · 2020-03-20T23:00:00Z

In a future PR, it could probably be made a setting -- global, though.

mdtauk · 2020-03-20T23:09:09Z

If it is implemented, it should work with the new Beam cursor options.

DHowett-MSFT · 2020-03-20T23:10:33Z

@mdtauk that is not an i-beam mouse cursor. whatever that is works with Terminal as of v0.10 (or v0.11? which is not yet out; it merged recently.)

zadjii-msft

I'm okay with this, on one condition. I'd like to have a plan for what we're going to call the setting to disable this before we ship this, cause I'm a pointer kind of guy 😝

zadjii-msft · 2020-03-24T15:03:36Z

src/cascadia/TerminalControl/TermControl.cpp

+    {
+        // If the current focused element is a child element of searchbox,
+        // we do not send this event up to terminal
+        if (_searchBox && _searchBox->ContainsFocus())


Presumably this bit would go away with #4748?

src/cascadia/TerminalControl/TermControl.cpp

zadjii-msft · 2020-03-24T15:09:43Z

src/cascadia/TerminalControl/TermControl.cpp

+        if (_oldCursor) // if we have an active cursor transition
+        {
+            auto coreWindow = Window::Current().CoreWindow();
+            coreWindow.PointerCursor(_CanSendVTMouseInput() ? _pointerCursor : _textCursor);


Should we have a helper method that's just "set the PointerCursor to the correct cursor for our current mouse input mode"?

DHowett-MSFT · 2020-03-24T18:05:33Z

So, I think this is your setting:

Cheekiness aside, I'm not averse to speccing a global setting that configures how the cursor works -- but it will be a case of users opting for less expressiveness/fewer features, so we should almost certainly measure its use.

DHowett-MSFT · 2020-03-24T23:52:18Z

This is in selfhost. Give it a feel.

zadjii-msft · 2020-03-25T13:17:33Z

The cursor remains an I-beam when I mouse over the tabs
If I open tmux (with mouse mode) in one tab, then hover another tab, the cursor switches back to the I-beam, and stays in an I beam even if I click inside tmux

zadjii-msft · 2020-04-01T13:03:15Z

showerthought: what if we just always turned the cursor back into an arrow, then let the new control change it to whatever they want? Presumably one control's PointerExited is fired before the next control's PointerEntered, right? Or does that cause flickering?

Additionally: Are we planning on putting this is 1.0?

DHowett-MSFT · 2020-04-01T20:46:18Z

not sure about 1.0. My concern with always setting Arrow is that what if they're hovering with a pen? I dunno, I kinda wanna ask AustinL.

egmontkob · 2020-05-02T22:39:58Z

So this is about the mouse pointer (mouse cursor), and not the text insertion cursor. I legit had to read the thread halfway through to realize it.

Don't you guys always confuse these two? I do. Similar names, the word "cursor" overloaded for them, and both possibly being of "I-beam" shape.

My preference is to say "mouse pointer" for, well, that one; without using the word "cursor". Do you guys have a preferred terminology?

bropines · 2020-05-03T11:51:31Z

@bropines похоже, что вы бежите в #4448

Thank you very much. I wouldn't have guessed it myself

DHowett-MSFT · 2020-05-05T01:41:28Z

@egmontkob yep, this is about the mouse pointer. I should endeavour to be better about saying "pointer" when I mean the thing the user points with. 😄

Alas, overloaded terms are pervasive in our industry. They're so hard to escape.

DHowett-MSFT · 2020-05-05T01:41:41Z

(And yeah, we get them mixed up all the time.)

carlos-zamora · 2020-05-28T21:44:51Z

src/cascadia/TerminalControl/TermControl.h

+        winrt::Windows::UI::Core::CoreCursor _textCursor;
+        winrt::Windows::UI::Core::CoreCursor _pointerCursor;


(Correct me if I'm wrong) It looks like you only set these in the constructor. Why not just make them constexpr in the namespace?

they're winrt objects. it sucks.

jsoref · 2020-05-28T22:28:16Z

The conflicts shouldn't be hard to resolve whitelist was renamed to expect -- If you need help, I can help on Sunday.

angelog0 · 2020-09-11T22:46:59Z

All the decent Terminals I know have this behavior: when the mouse pointer is over them it changes into a sort of I. This makes selecting text more intuitive and practical...

DHowett · 2020-09-11T22:49:04Z

And you are commenting on this open pull request that does exactly this so as to move it along?

dufferzafar · 2021-03-09T10:04:55Z

Is this still being worked on?

DHowett · 2021-03-10T00:28:55Z

Not actively.

miniksa · 2022-01-14T16:37:28Z

Closing as it's super stale, but not deleting the branch in case someone wants to dig it up again one day.

zadjii-msft · 2023-11-20T14:30:28Z

To add some notes that never made it here a few years back:

I believe there was no good way for us to set the mouse pointer for a single control in XAML. A control could change the cursor in PointerEntered, but IIRC there's a race between PointerEnter's and PointerExits. So when you've got an app that's got all sorts of mixed UI elements, some that want the cursor to be an I-beam and some that want the arrow, well now you're stuck. As you hover over different elements, they'll fight over who's actually setting the cursor to what.

DHowett-MSFT mentioned this pull request Mar 20, 2020

Mouse pointer should be text and not arrow one #1441

Open

Fix SA (well, guess what SA was mad about) and format

2e04851

DHowett-MSFT marked this pull request as ready for review March 20, 2020 22:38

zadjii-msft reviewed Mar 24, 2020

View reviewed changes

Merge remote-tracking branch 'origin/master' into dev/duhowett/eyebeam

1ae08d4

DHowett added 4 commits March 25, 2020 15:47

Merge remote-tracking branch 'origin' into dev/duhowett/eyebeam

6db3c8f

Merge remote-tracking branch 'origin/master' into dev/duhowett/eyebeam

698bca2

whitelist IBeam

61e46e3

Migrate spelling-0.0.19 changes from main

34f83a6

This comment was marked as off-topic.

Sign in to view

zadjii-msft added this to the Terminal v1.x milestone Apr 10, 2020

DHowett-MSFT mentioned this pull request May 2, 2020

Support Mouse Vanish (Hide pointer while typing) #5699

Closed

DHowett mentioned this pull request May 18, 2020

Linux terminal like selection behavior #5943

Closed

carlos-zamora reviewed May 28, 2020

View reviewed changes

zadjii-msft assigned DHowett Aug 18, 2020

zadjii-msft removed this from the Terminal v1.x milestone Aug 18, 2020

microsoft-github-updates bot changed the base branch from master to main October 22, 2020 00:27

ghost added Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. labels Oct 22, 2020

zadjii-msft mentioned this pull request Feb 1, 2021

Preview - Mouse cursor doesn't reappear when switching workspaces during mouse hide #8958

Open

DHowett marked this pull request as draft March 10, 2021 00:29

This comment has been minimized.

Sign in to view

ghost dismissed a stale review via 34f83a6 November 2, 2021 13:46

miniksa closed this Jan 14, 2022

carlos-zamora mentioned this pull request Jul 15, 2022

Make selection have an exclusive end #13516

Closed

9 tasks

zadjii-msft mentioned this pull request Jul 22, 2024

Add support for resizing panes with mouse #16895

Open

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Switch to the I-beam cursor when hovering over the terminal #5028

Switch to the I-beam cursor when hovering over the terminal #5028

DHowett-MSFT commented Mar 20, 2020 •

edited

Loading

zadjii-msft commented Mar 20, 2020

DHowett-MSFT commented Mar 20, 2020

mdtauk commented Mar 20, 2020

DHowett-MSFT commented Mar 20, 2020

zadjii-msft left a comment

zadjii-msft Mar 24, 2020

DHowett-MSFT Mar 24, 2020

zadjii-msft Mar 24, 2020

DHowett-MSFT commented Mar 24, 2020

DHowett-MSFT commented Mar 24, 2020

zadjii-msft commented Mar 25, 2020

zadjii-msft commented Apr 1, 2020

DHowett-MSFT commented Apr 1, 2020 •

edited

Loading

This comment was marked as off-topic.

This comment was marked as off-topic.

egmontkob commented May 2, 2020

bropines commented May 3, 2020

DHowett-MSFT commented May 5, 2020

DHowett-MSFT commented May 5, 2020

carlos-zamora May 28, 2020

DHowett May 28, 2020

jsoref commented May 28, 2020

angelog0 commented Sep 11, 2020

DHowett commented Sep 11, 2020

dufferzafar commented Mar 9, 2021

DHowett commented Mar 10, 2021

This comment has been minimized.

miniksa commented Jan 14, 2022

zadjii-msft commented Nov 20, 2023

		winrt::Windows::UI::Core::CoreCursor _textCursor;
		winrt::Windows::UI::Core::CoreCursor _pointerCursor;

Switch to the I-beam cursor when hovering over the terminal #5028

Switch to the I-beam cursor when hovering over the terminal #5028

Conversation

DHowett-MSFT commented Mar 20, 2020 • edited Loading

Detailed Description of the Pull Request / Additional comments

zadjii-msft commented Mar 20, 2020

DHowett-MSFT commented Mar 20, 2020

mdtauk commented Mar 20, 2020

DHowett-MSFT commented Mar 20, 2020

zadjii-msft left a comment

Choose a reason for hiding this comment

zadjii-msft Mar 24, 2020

Choose a reason for hiding this comment

DHowett-MSFT Mar 24, 2020

Choose a reason for hiding this comment

zadjii-msft Mar 24, 2020

Choose a reason for hiding this comment

DHowett-MSFT commented Mar 24, 2020

DHowett-MSFT commented Mar 24, 2020

zadjii-msft commented Mar 25, 2020

zadjii-msft commented Apr 1, 2020

DHowett-MSFT commented Apr 1, 2020 • edited Loading

This comment was marked as off-topic.

This comment was marked as off-topic.

egmontkob commented May 2, 2020

bropines commented May 3, 2020

DHowett-MSFT commented May 5, 2020

DHowett-MSFT commented May 5, 2020

carlos-zamora May 28, 2020

Choose a reason for hiding this comment

DHowett May 28, 2020

Choose a reason for hiding this comment

jsoref commented May 28, 2020

angelog0 commented Sep 11, 2020

DHowett commented Sep 11, 2020

dufferzafar commented Mar 9, 2021

DHowett commented Mar 10, 2021

This comment has been minimized.

miniksa commented Jan 14, 2022

zadjii-msft commented Nov 20, 2023

DHowett-MSFT commented Mar 20, 2020 •

edited

Loading

DHowett-MSFT commented Apr 1, 2020 •

edited

Loading