Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the window border actually follow the user's theme #5105

Merged
1 commit merged into from
Mar 24, 2020
Merged

Make the window border actually follow the user's theme #5105

1 commit merged into from
Mar 24, 2020

Conversation

DHowett-MSFT
Copy link
Contributor

Summary of the Pull Request

One of our great contributors already hooked up all the logic for this,
we just needed a theme library that could handle the request.

PR Checklist

@DHowett
Make the window border actually follow the user's theme
d2067a7 
One of our great contributors already hooked up all the logic for this,
we just needed a theme library that could handle the request.

Fixes #4980.
@DHowett-MSFT
Copy link
Contributor Author

Most of the diffs here are updating the nuget package 😄

@DHowett-MSFT
Copy link
Contributor Author

@msftbot merge this in 5 minutes

@ghost ghost added the AutoMerge Marked for automatic merge by the bot when requirements are met label Mar 24, 2020
@ghost
Copy link

ghost commented Mar 24, 2020

Hello @DHowett-MSFT!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Tue, 24 Mar 2020 19:36:46 GMT, which is in 5 minutes

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@mdtauk
Copy link

mdtauk commented Mar 24, 2020

Does this make the border follow the System theme, or the app settings JSON "RequestedTheme"

@DHowett-MSFT
Copy link
Contributor Author

The application's currently-active theme.

@DHowett-MSFT
Copy link
Contributor Author

The border currently follows the system theme.

@mdtauk
Copy link

mdtauk commented Mar 24, 2020

Thank you @DHowett-MSFT

@ghost ghost merged commit 176badf into master Mar 24, 2020
@ghost ghost deleted the dev/duhowett/really_theme branch March 24, 2020 19:47
@ghost
Copy link

ghost commented Apr 22, 2020

🎉Windows Terminal Preview v0.11.1121.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Apr 22, 2020
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zadjii-msft zadjii-msft zadjii-msft approved these changes

@carlos-zamora carlos-zamora carlos-zamora approved these changes

Assignees
No one assigned
Labels
AutoMerge Marked for automatic merge by the bot when requirements are met
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

White border when Terminal is dark while Windows is in Light theme
5 participants
@DHowett-MSFT @mdtauk @carlos-zamora @zadjii-msft @DHowett