Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the Tango color schemes for Terminal and ColorTool #5305

Merged
merged 1 commit into from
Apr 14, 2020
Merged

Add the Tango color schemes for Terminal and ColorTool #5305

merged 1 commit into from
Apr 14, 2020

Conversation

rkitover
Copy link
Contributor

@rkitover rkitover commented Apr 10, 2020 •
edited
Loading

The Tango color scheme is part of the Tango Desktop Project, which was
released to the public domain in 2009.

More information:

http://tango-project.org/

Add the "Tango Dark" and "Tango Light" color scheme presets.

Signed-off-by: Rafael Kitover rkitover@gmail.com

PR Checklist

@rkitover
Add Tango Color Scheme.
033df52 
The Tango color scheme is part of the Tango Desktop Project, which was
released to the public domain in 2009.

More information:

http://tango-project.org/

Add the "Tango Dark" and "Tango Light" color scheme presets.

- Fix microsoft#5281.

Signed-off-by: Rafael Kitover <rkitover@gmail.com>
@zadjii-msft
Copy link
Member

@msftbot make sure both @cinnamon-msft and @DHowett-MSFT sign off on this

@ghost ghost added the AutoMerge Marked for automatic merge by the bot when requirements are met label Apr 10, 2020
@ghost
Copy link

ghost commented Apr 10, 2020

Hello @zadjii-msft!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

zadjii-msft
zadjii-msft approved these changes Apr 10, 2020
View reviewed changes
Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with this, but I want to make sure the rest of the team is too. Also, I don't know enough about licensing to be sure this is enough. "Public Domain" sure seems good enough to me, but IANAL

@zadjii-msft zadjii-msft added Area-Settings Issues related to settings and customizability, for console or terminal Product-Terminal The new Windows Terminal. labels Apr 10, 2020
@skyline75489
Copy link
Collaborator

I didn't even realize we got so many color schemes now. Perhaps cuz I'm using a very old profile from version 0.6 or something. If this is possible, I'm gonna add Dracula (which is MIT licensed) as soon as I can.

@cinnamon-msft
Copy link
Contributor

I think defaults-universal.json also needs to be updated?

@rkitover
Copy link
Contributor Author

@cinnamon-msft I only saw any color schemes defined in defaults.json.

@zadjii-msft
Copy link
Member

@cinnamon-msft They might be off the hook on that - defaults-universal only has "Vintage" as a scheme, and it's not like users can edit the settings on that version anyways 😄

@rkitover
Copy link
Contributor Author

Sorry, the "Vintage" theme is indeed in defaults-universal.json, I missed that.

I can copy all the themes to defaults-universal.json, but this breaks DRY.

Why don't we make a color-schemes.json or some such?

@zadjii-msft
Copy link
Member

@rkitover Don't worry about it, defaults-universal.json is really only used internally as a testing tool.

There's #2933, which I'm roughly using as "be able to import settings from other files as well as profiles.json" that would enable having additional files for settings (like a color-schemes.json), but that's way out of scope for 1.0 at this point 😄

@DHowett-MSFT DHowett-MSFT removed the AutoMerge Marked for automatic merge by the bot when requirements are met label Apr 14, 2020
DHowett-MSFT
DHowett-MSFT approved these changes Apr 14, 2020
View reviewed changes
Copy link
Contributor

@DHowett-MSFT DHowett-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it. thank you!

@DHowett-MSFT DHowett-MSFT changed the title Add Tango Color Scheme. Add the Tango color schemes for Terminal and ColorTool Apr 14, 2020
@DHowett-MSFT DHowett-MSFT merged commit ea61aa3 into microsoft:master Apr 14, 2020
@rkitover rkitover deleted the tango-color-theme branch April 14, 2020 18:58
@ghost
Copy link

ghost commented Apr 22, 2020

🎉Windows Terminal Preview v0.11.1121.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Apr 22, 2020
Closed
@rkitover rkitover mentioned this pull request Apr 27, 2020
Merged
4 tasks
DHowett-MSFT pushed a commit that referenced this pull request Apr 27, 2020
@rkitover
Improve default foregrounds for Tango schemes (#5598)
b4c9c0c 
Followup to ea61aa3.

The default foreground in the iTerm2 defaults for the Tango Dark color
scheme is too bright, use the value for ANSI 7 (white) instead.

References #5305

Sorry, I should have really done this in the original PR.

Signed-off-by: Rafael Kitover <rkitover@gmail.com>
DHowett-MSFT pushed a commit that referenced this pull request Apr 27, 2020
@rkitover @DHowett
Improve default foregrounds for Tango schemes (#5598)
962716e 
Followup to ea61aa3.

The default foreground in the iTerm2 defaults for the Tango Dark color
scheme is too bright, use the value for ANSI 7 (white) instead.

References #5305

Sorry, I should have really done this in the original PR.

Signed-off-by: Rafael Kitover <rkitover@gmail.com>
(cherry picked from commit b4c9c0c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cinnamon-msft cinnamon-msft cinnamon-msft approved these changes

@zadjii-msft zadjii-msft zadjii-msft approved these changes

@DHowett-MSFT DHowett-MSFT DHowett-MSFT approved these changes

Assignees
No one assigned
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Please Support the Tango Color Theme
5 participants
@rkitover @zadjii-msft @skyline75489 @cinnamon-msft @DHowett-MSFT