Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SGR indexed colors to distinguish Indexed256 color (and more) #5834

Merged
9 commits merged into from
May 27, 2020
Merged

Fix SGR indexed colors to distinguish Indexed256 color (and more) #5834

9 commits merged into from
May 27, 2020

Commits on May 10, 2020

  1. Distinguish between indexed colors from the 16 color palette (which c… 

    …an be brightened), and the 256 color palette (which can't).
    @j4james
    j4james committed May 10, 2020
    Configuration menu
    Copy the full SHA
    d5aabb4 View commit details
    Browse the repository at this point in the history

  2. Make the terminal dispatcher use the 256 color index format for SGR 3… 

    …8:5 and 48:5 escape sequences.
    @j4james
    j4james committed May 10, 2020
    Configuration menu
    Copy the full SHA
    414c727 View commit details
    Browse the repository at this point in the history

  3. Update unit tests to account for the updated index color formats.

    @j4james
    j4james committed May 10, 2020
    Configuration menu
    Copy the full SHA
    6ca9015 View commit details
    Browse the repository at this point in the history

  4. Avoid directly copying the color table with memmove.

    @j4james
    j4james committed May 10, 2020
    Configuration menu
    Copy the full SHA
    1814a58 View commit details
    Browse the repository at this point in the history

  5. Remove some unnecessary functions that made the code harder to follow.

    @j4james
    j4james committed May 10, 2020
    Configuration menu
    Copy the full SHA
    c06c575 View commit details
    Browse the repository at this point in the history

  6. Combine the 16 and 256 color tables, and use string_views when passin… 

    …g the tables around.
    @j4james
    j4james committed May 10, 2020
    Configuration menu
    Copy the full SHA
    a4c23a6 View commit details
    Browse the repository at this point in the history

  7. Make the conhost dispatcher use the 256 color index format for SGR 38… 

    …:5 and 48:5 escape sequences.
    @j4james
    j4james committed May 10, 2020
    Configuration menu
    Copy the full SHA
    f321051 View commit details
    Browse the repository at this point in the history

  8. Update unit tests to account for the corrected interpretation of inde… 

    …xed colors.
    @j4james
    j4james committed May 10, 2020
    Configuration menu
    Copy the full SHA
    020b0d1 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2020

  1. Make the GraphicsSingleTests clearer by explicitly initialising the e… 

    …xpected attribute before overriding the foreground index.
    @j4james
    j4james committed May 14, 2020
    Configuration menu
    Copy the full SHA
    beeb0c9 View commit details
    Browse the repository at this point in the history