Make sure to update the maximize button's visual state on launch #5988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-User Interface
DHowett
reviewed
May 21, 2020
Comment on lines
+209
to
+212
| // GH#3440 - When the titlebar is loaded (officially added to our UI tree), | ||
| // then make sure to update it's visual state to reflect if we're in the | ||
| // maximized state on launch. | ||
| _titlebar.Loaded([this](auto&&, auto&&) { _OnMaximizeChange(); }); |
There was a problem hiding this comment.
Scary that Loaded hasn't happened yet! Guess it makes sense tho.
DHowett
approved these changes
May 21, 2020
ghost
requested review from
carlos-zamora
approved these changes
May 21, 2020
DHowett
added
the
AutoMerge
|
Hello @DHowett! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
jelster
pushed a commit
to jelster/terminal
that referenced
this pull request
May 28, 2020
…rosoft#5988) ## Summary of the Pull Request This is an enormously trivial nit - when we launch maximized, we don't draw the maximize button in the "restore" state. This PR changes the terminal to manually update the Maximize button on launch, once the titlebar is added to the UI tree. ## PR Checklist * [x] Closes microsoft#3440 * [x] I work here * [ ] Tests added/passed * [n/a] Requires documentation to be updated
|
🎉 Handy links: |
ghost
mentioned this pull request
DHowett
pushed a commit
that referenced
this pull request
Jun 24, 2020
## Summary of the Pull Request This is an enormously trivial nit - when we launch maximized, we don't draw the maximize button in the "restore" state. This PR changes the terminal to manually update the Maximize button on launch, once the titlebar is added to the UI tree. ## PR Checklist * [x] Closes #3440 * [x] I work here * [ ] Tests added/passed * [n/a] Requires documentation to be updated (cherry picked from commit 2af722b)
|
🎉 Handy links: |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This is an enormously trivial nit - when we launch maximized, we don't draw the maximize button in the "restore" state.
This PR changes the terminal to manually update the Maximize button on launch, once the titlebar is added to the UI tree.
PR Checklist