Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ubuntu-specific background color #6150

Closed
wants to merge 1 commit into from
Closed

Add ubuntu-specific background color #6150

wants to merge 1 commit into from

Conversation

NatoBoram
Copy link

Summary of the Pull Request

src\cascadia\TerminalApp\WslDistroGenerator.cpp :

if (distName.rfind("Ubuntu", 0) == 0) {
    WSLDistro.SetColorScheme({ L"Tango Dark" });
    WSLDistro.SetDefaultBackground({ L"#300a24" });
} else {
    WSLDistro.SetColorScheme({ L"Campbell" });
}

References

PR Checklist

  • Closes Add Yaru scheme #6085
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: Add Yaru scheme #6085

Detailed Description of the Pull Request / Additional comments

This changes WSL Ubuntu's default theme to match Ubuntu's theme, Tango Dark, and adds Ubuntu's background colour.

Validation Steps Performed

I couldn't build the project to validate that it works. Maintainers are free to edit the PR.

@ghost ghost added Area-Settings Issues related to settings and customizability, for console or terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. labels May 22, 2020
@DHowett DHowett requested a review from zadjii-msft June 15, 2020 20:22
@zadjii-msft
Copy link
Member

Thanks for the contribution here!

I really like the idea of this PR, but I have some qualms about it. I'm a little worried about the idea of us changing the UX for distros on their behalf. If this were something that Canonical was requesting from us, I'd probably be more open to the idea, but I don't really want to be in the business of specializing the appearance for a distro without their input.

I think the long-term vision here is that distro owners themselves might be able to provide some sort of configuration blob that we'd be able to ingest. That way, the distro maintainer could specify the way they'd like their terminal profile's to look, and we could just use what they've provided to us. I know that @DHowett has been noodling on this for a while now. I'll leave it to him to make the final call, but I'm leaning towards rejecting this PR.

@NatoBoram
Copy link
Author

It would be absolutely amazing to have distro maintainers come out and give a JSON file that we can use, but I don't think we should wait for them to do it.

@microsoft-github-updates microsoft-github-updates bot changed the base branch from master to main October 22, 2020 00:27
@zadjii-msft
Copy link
Member

Hey thanks for the contribution here! I think long term, the solution we're pursuing is to have Canonical be able to ship "settings fragments" alongside their package, what will let them configure the settings for the dynamic Ubuntu profiles however they'd like. I believe they've already expressed interest in manually setting the scheme and background color (and possibly also the font).

I'm gonna close this in favor of #7584 / #7632. Thanks!

@NatoBoram
Copy link
Author

I really hope to see their theme soon :)

@NatoBoram NatoBoram deleted the ubuntu-default branch November 18, 2020 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Yaru scheme
3 participants