Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce a color compatibility hack, but only for PowerShells #6810

Merged

Commits on Jul 7, 2020

  1. Reintroduce a color compatibility hack, but only for the BG color

    There is going to be a very long tail of applications that will
    explicitly request VT SGR 40 when what they really want is to
    SetConsoleTextAttribute() with a black background. Instead of making
    those applications look bad (and therefore making us look bad, because
    we're releasing this as an update to something that "looks good"
    already), we're introducing this compatibility hack. Before the color
    reckoning in #6698 + #6506, *every* color was subject to being
    spontaneously and erroneously turned into the default color. Now, only
    the 16-color palette value that matches the active console background
    color will be destroyed.  This is not intended to be a long-term
    solution. This comment will be discovered in forty years(*) time and
    people will laugh at my hubris.
    
    Removal, or final remediation, will be tracked by #6807.
    
    *it doesn't matter when you're reading this, it will always be 40 years
    from now.
    DHowett committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    2d48d29 View commit details
    Browse the repository at this point in the history
  2. code format

    DHowett committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    1e1e512 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3f67efa View commit details
    Browse the repository at this point in the history
  4. Fix the tests.

    DHowett committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    5b3a2bd View commit details
    Browse the repository at this point in the history
  5. Treat INTENSITY properly

    DHowett committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    e68c867 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2020

  1. Configuration menu
    Copy the full SHA
    27f898a View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2020

  1. add a test for the quirk

    DHowett committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    9ecfeb7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f712c51 View commit details
    Browse the repository at this point in the history