Adding keymapping for access to Settings

[timheuer]

First stab at adding a key mapping to settings so I can quickly access it instead of using a mouse :-)

[zadjii-msft]

I'm a little wary of binding Ctrl+S by default for this. Maybe Ctrl+Shift+S? But otherwise this looks good and righteous to me!

[timheuer]

CTRL+SHIFT+S would work here as well. I thought about how CTRL+S is often thought of as 'save' and would it interfere with something that might have focus in conhost when a specific terminal was there but couldn't think of it. ALT+S was another option I thought of but I then was honestly just following CTRL+T pattern for tab to be consistent with the modifier key.

[factormystic]

Some thoughts

• should the keybinding come from a setting (or is loading keybinding from config a separate effort)
• personally I think that registering any type of mnemonic shortcut should be done with extreme caution because one man's settings is another mans save, as you already discovered
• is there a shortcut from any other app you could crib instead? Not sure what VS uses by default, but VS Code is ctrl + ,

[DHowett-MSFT]

Yeah, I think Ctrl+, is the industry standard for opening settings panels.

Bonus: it doesn't conflict with any VT sequences!

[mKay00]

@factormystic keybindings will be remappable in the settings, see #748

[DHowett-MSFT]

@timheuer Thanks!