Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the renderer color calculations #6853

Merged
7 commits merged into from
Jul 10, 2020
Merged

Refactor the renderer color calculations #6853

7 commits merged into from
Jul 10, 2020

Commits on Jul 9, 2020

  1. Refactor the foreground and background color calculations into a sing… 

    …le method in the TextAttribute class.
    @j4james
    j4james committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    25d324c View commit details
    Browse the repository at this point in the history

  2. Update the clipboard code to use a single call for both foreground an… 

    …d background color calculations.
    @j4james
    j4james committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    34cbed6 View commit details
    Browse the repository at this point in the history

  3. Remove the unused GetForegroundColor and GetBackgroundColor methods.

    @j4james
    j4james committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    86a5f2a View commit details
    Browse the repository at this point in the history

  4. Update unit tests to replace the LookupForegroundColor and LookupBack… 

    …groundColor methods.
    @j4james
    j4james committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    94db3d1 View commit details
    Browse the repository at this point in the history

  5. Update unit tests to replace the CalculateRgbForeground and Calculate… 

    …RgbBackground methods.
    @j4james
    j4james committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    2922468 View commit details
    Browse the repository at this point in the history

  6. Check if there are any lines to paint in the grid line renderer befor… 

    …e looking up the color.
    @j4james
    j4james committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    8a7830c View commit details
    Browse the repository at this point in the history

  7. Fix some constness.

    @j4james
    j4james committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    636b8f7 View commit details
    Browse the repository at this point in the history