Add support for commands iterable on color schemes #7329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zadjii-msft
added
Area-User Interface
DHowett
reviewed
Aug 18, 2020
| { | ||
| "name": "iterable command ${scheme.name}", | ||
| "iterateOn": "schemes", | ||
| "command": { "action": "splitPane", "profile": "${scheme.name}" } |
There was a problem hiding this comment.
LOL, well, i mean.. it's effective for sure
DHowett
reviewed
Aug 18, 2020
DHowett
reviewed
Aug 18, 2020
carlos-zamora
approved these changes
Aug 18, 2020
DHowett
requested changes
Aug 18, 2020
ghost
added
the
Needs-Author-Feedback
ghost
removed
the
Needs-Author-Feedback
DHowett
approved these changes
Aug 19, 2020
zadjii-msft
added
the
AutoMerge
|
Hello @zadjii-msft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
52 tasks
MichelleTanPY
pushed a commit
to MichelleTanPY/terminal
that referenced
this pull request
Aug 20, 2020
## Summary of the Pull Request  Allows for creating commands that iterate over the user's color schemes. Also adds a top-level nested command to `defaults.json` that allows the user to select a color scheme (pictured above). I'm not sure there are really any other use cases that make sense, but it _really_ makes sense for this one. ## References * microsoft#5400 - cmdpal megathread * made possible by microsoft#6856, _and support from viewers like you._ * All this is being done in pursuit of microsoft#6689 ## PR Checklist * [x] Closes wait what? I could have swore there was an issue for this one... * [x] I work here * [x] Tests added/passed * [ ] Requires documentation to be updated - okay maybe now I'll write some docs ## Detailed Description of the Pull Request / Additional comments Most of the hard work for this was already done in microsoft#6856. This is just another thing to iterate over. ## Validation Steps Performed * Played with this default command. It works great. * Added tests.
|
🎉 Handy links: |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Allows for creating commands that iterate over the user's color schemes. Also adds a top-level nested command to
defaults.jsonthat allows the user to select a color scheme (pictured above). I'm not sure there are really any other use cases that make sense, but it really makes sense for this one.References
PR Checklist
Detailed Description of the Pull Request / Additional comments
Most of the hard work for this was already done in #6856. This is just another thing to iterate over.
Validation Steps Performed