Keep degenerate UIA text ranges degenerate after movement #7530

codeofdusk · 2020-09-04T04:09:30Z

Conhost expands UIA text ranges when moved. This means that degenerate
ranges become non-degenerate after movement, leading to odd behaviour
from UIA clients. This PR doesn't expand degenerate ranges, but rather
keeps them degenerate by moving _end to the newly-changed _start.

Tested in the NVDA Python console (cases with setEndPoint and
compareEndPoints described in #7342). Also ran the logic by
@michaelDCurran.

Closes #7342 and nvaccess/nvda#11288

Also fixes an issue privately reported to
me by @Simon818 with copy/paste from review cursor which originally lead
me to believe the issue was with moveEndPointByRange.

carlos-zamora

This test is failing:

terminal/src/interactivity/win32/ut_interactivity_win32/UiaTextRangeTests.cpp

Line 578 in 9279b7a

MoveTest{

Not too bad though. Just change this line to:

{4, 0+1}

Bonus points if you add a similar test to CanMoveByLine tests here:

terminal/src/interactivity/win32/ut_interactivity_win32/UiaTextRangeTests.cpp

Line 619 in 9279b7a

TEST_METHOD(CanMoveByLine)

src/types/UiaTextRangeBase.cpp

carlos-zamora · 2020-09-04T16:20:05Z

Forgot to say, other than that, it looks good! Thanks!

Co-authored-by: Carlos Zamora <carlos.zamora@microsoft.com>

carlos-zamora

We're close 😊

Also, we have a code formatter. To run it, do this in your terminal:

# in pwsh, go to the repo's directory
Import-Module .\tools\OpenConsole.psm1
Invoke-CodeFormat

src/interactivity/win32/ut_interactivity_win32/UiaTextRangeTests.cpp

…ts.cpp Co-authored-by: Carlos Zamora <carlos.zamora@microsoft.com>

DHowett

This is excellent, and a very good catch. Thank you 😄L

ghost · 2020-09-04T20:37:42Z

Hello @DHowett!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.

DHowett · 2020-09-04T20:37:47Z

@carlos-zamora double-tap plz

codeofdusk · 2020-09-11T06:44:51Z

Any rough timeline for when this will make it to insider inbox?

DHowett · 2020-09-16T01:27:57Z

This is merging to Windows today; it will be a couple weeks before it goes out to Insiders. 😄 Thanks again for the contribution.

I'll let you know when it's out.

@michaelDCurran

Conhost expands UIA text ranges when moved. This means that degenerate ranges become non-degenerate after movement, leading to odd behaviour from UIA clients. This PR doesn't expand degenerate ranges, but rather keeps them degenerate by moving `_end` to the newly-changed `_start`. Tested in the NVDA Python console (cases with `setEndPoint` and `compareEndPoints` described in #7342). Also ran the logic by @michaelDCurran. Closes #7342 Almost definitely addresses nvaccess/nvda#11288 (although I'll need to test with my Braille display). Also fixes an issue privately reported to me by @Simon818 with copy/paste from review cursor which originally lead me to believe the issue was with `moveEndPointByRange`. (cherry picked from commit 7a03f75)

ghost · 2020-09-22T16:00:51Z

🎉Windows Terminal v1.3.2651.0 has been released which incorporates this pull request.:tada:

Handy links:

ghost · 2020-09-22T16:01:06Z

🎉Windows Terminal Preview v1.4.2652.0 has been released which incorporates this pull request.:tada:

Handy links:

ghost added Area-Accessibility Issues related to accessibility Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Conhost For issues in the Console codebase Product-Terminal The new Windows Terminal. labels Sep 4, 2020

Keep degenerate UIA text ranges degenerate after movement.

3eb15fc

codeofdusk force-pushed the dev/codeofusk/i7342 branch from ebfd789 to 3eb15fc Compare September 4, 2020 14:00

carlos-zamora requested changes Sep 4, 2020

View reviewed changes

src/types/UiaTextRangeBase.cpp Outdated Show resolved Hide resolved

ghost added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Sep 4, 2020

Update src/types/UiaTextRangeBase.cpp

c9f3661

Co-authored-by: Carlos Zamora <carlos.zamora@microsoft.com>

ghost removed the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Sep 4, 2020

codeofdusk added 2 commits September 4, 2020 13:18

Address review action.

f8e8af0

Add automated tests.

2d0427a

carlos-zamora requested changes Sep 4, 2020

View reviewed changes

src/interactivity/win32/ut_interactivity_win32/UiaTextRangeTests.cpp Outdated Show resolved Hide resolved

src/interactivity/win32/ut_interactivity_win32/UiaTextRangeTests.cpp Outdated Show resolved Hide resolved

ghost added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Sep 4, 2020

Review actions.

b7973aa

ghost removed the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Sep 4, 2020

I'm obviously not commatose enough...

a031ee3

codeofdusk mentioned this pull request Sep 4, 2020

UI Automation in Windows Console: make default in FORMATTED consoles (Windows 11 Sun Valley 2) nvaccess/nvda#10964

Merged

carlos-zamora requested changes Sep 4, 2020

View reviewed changes

src/interactivity/win32/ut_interactivity_win32/UiaTextRangeTests.cpp Outdated Show resolved Hide resolved

ghost added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Sep 4, 2020

Update src/interactivity/win32/ut_interactivity_win32/UiaTextRangeTes…

e01c578

…ts.cpp Co-authored-by: Carlos Zamora <carlos.zamora@microsoft.com>

ghost removed the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Sep 4, 2020

DHowett approved these changes Sep 4, 2020

View reviewed changes

DHowett added the AutoMerge Marked for automatic merge by the bot when requirements are met label Sep 4, 2020

carlos-zamora approved these changes Sep 4, 2020

View reviewed changes

ghost merged commit 7a03f75 into microsoft:master Sep 4, 2020

codeofdusk deleted the dev/codeofusk/i7342 branch September 4, 2020 21:30

codeofdusk mentioned this pull request Sep 4, 2020

revue cursor: strange behavior in windows-terminal with braille nvaccess/nvda#11288

Closed

Sidneys1 mentioned this pull request Sep 7, 2020

Windows Terminal Dev Build crashes on start as of 5330759c #7553

Closed

codeofdusk mentioned this pull request Sep 18, 2020

UIA in Console and WSL: crashes in some contexts nvaccess/nvda#11428

Closed

ghost mentioned this pull request Sep 22, 2020

UIA: degenerate text ranges not degenerate after move #7342

Closed

carlos-zamora mentioned this pull request Oct 1, 2020

Properly handle and test a11y movement at end of buffer #7792

Merged

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Keep degenerate UIA text ranges degenerate after movement #7530

Keep degenerate UIA text ranges degenerate after movement #7530

codeofdusk commented Sep 4, 2020 •

edited

Loading

carlos-zamora left a comment

carlos-zamora commented Sep 4, 2020

carlos-zamora left a comment

DHowett left a comment

ghost commented Sep 4, 2020

DHowett commented Sep 4, 2020

codeofdusk commented Sep 11, 2020

DHowett commented Sep 16, 2020

ghost commented Sep 22, 2020

ghost commented Sep 22, 2020

Keep degenerate UIA text ranges degenerate after movement #7530

Keep degenerate UIA text ranges degenerate after movement #7530

Conversation

codeofdusk commented Sep 4, 2020 • edited Loading

carlos-zamora left a comment

Choose a reason for hiding this comment

carlos-zamora commented Sep 4, 2020

carlos-zamora left a comment

Choose a reason for hiding this comment

DHowett left a comment

Choose a reason for hiding this comment

ghost commented Sep 4, 2020

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

DHowett commented Sep 4, 2020

codeofdusk commented Sep 11, 2020

DHowett commented Sep 16, 2020

ghost commented Sep 22, 2020

ghost commented Sep 22, 2020

codeofdusk commented Sep 4, 2020 •

edited

Loading

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.