Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the "visual representation" optimization for hyperlinks #7738

Merged
1 commit merged into from
Sep 28, 2020
Merged

Fix the "visual representation" optimization for hyperlinks #7738

1 commit merged into from
Sep 28, 2020

Conversation

PankajBhojwani
Copy link
Contributor

@PankajBhojwani PankajBhojwani commented Sep 25, 2020 •
edited by DHowett
Loading

Closes #7700

@ghost ghost added Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Conpty For console issues specifically related to conpty labels Sep 25, 2020
@DHowett DHowett changed the title Fix for hyperlink rendering Fix the "visual representation" optimization for hyperlinks Sep 25, 2020
@DHowett DHowett added the AutoMerge Marked for automatic merge by the bot when requirements are met label Sep 28, 2020
@ghost
Copy link

ghost commented Sep 28, 2020

Hello @DHowett!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 3cf31fb into master Sep 28, 2020
@ghost ghost deleted the dev/pabhoj/link_render_fix branch September 28, 2020 23:49
DHowett pushed a commit that referenced this pull request Oct 19, 2020
@PankajBhojwani @DHowett
Fix the "visual representation" optimization for hyperlinks (#7738)
57ca2ec 
Closes #7700

(cherry picked from commit 3cf31fb)
@ghost
Copy link

ghost commented Nov 11, 2020

🎉Windows Terminal v1.4.3141.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Nov 11, 2020
Closed
@ghost
Copy link

ghost commented Nov 11, 2020

🎉Windows Terminal Preview v1.5.3142.0 has been released which incorporates this pull request.:tada:

Handy links:

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlos-zamora carlos-zamora carlos-zamora approved these changes

@DHowett DHowett DHowett approved these changes

Assignees
No one assigned
Labels
Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Conpty For console issues specifically related to conpty
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New 1.4 VT colors bug, foreground color not applied to " " (space) cells when hyperlinked
3 participants
@PankajBhojwani @DHowett @carlos-zamora