Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce IconConverter #7830

Merged
merged 6 commits into from
Oct 8, 2020
Merged

Introduce IconConverter #7830

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fad6ba0
Introduce IconConverter
carlos-zamora Oct 5, 2020
09b184e
rename IconPath w/ Icon
carlos-zamora Oct 6, 2020
de091c5
remove const from observable properties
carlos-zamora Oct 6, 2020
2fe20ba
resolve a few more comments
carlos-zamora Oct 6, 2020
d4231ac
remove const_cast
carlos-zamora Oct 8, 2020
c09cfc1
update schema
carlos-zamora Oct 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions doc/cascadia/profiles.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,13 @@
"pattern": "^\\{[a-fA-F0-9]{8}-[a-fA-F0-9]{4}-[a-fA-F0-9]{4}-[a-fA-F0-9]{4}-[a-fA-F0-9]{12}\\}$",
"type": "string"
},
"Icon": {
"description": "Image file location or an emoji to be used as an icon. Displays within the tab, the dropdown menu, and jumplist.",
"type": [
"string",
"null"
]
},
"ShortcutActionName": {
"enum": [
"adjustFontSize",
Expand Down Expand Up @@ -465,6 +472,14 @@
"type": "array"
}
]
},
"icon": { "$ref": "#/definitions/Icon" },
"name": {
"description": "The name that will appear in the command palette. If one isn't provided, the terminal will attempt to automatically generate a name.",
carlos-zamora marked this conversation as resolved.
Show resolved Hide resolved
"type": [
"string",
"null"
]
}
},
"required": [
Expand Down Expand Up @@ -810,10 +825,7 @@
"minimum": -1,
"type": "integer"
},
"icon": {
"description": "Image file location of the icon used in the profile. Displays within the tab and the dropdown menu.",
"type": ["string", "null"]
},
"icon":{ "$ref": "#/definitions/Icon" },
"name": {
"description": "Name of the profile. Displays in the dropdown menu.",
"minLength": 1,
Expand Down