Enable PgUp/PgDown and Home/End in the command palette

src/cascadia/TerminalApp/App.xaml

@@ -1,51 +1,59 @@
-<!-- Copyright (c) Microsoft Corporation. All rights reserved. Licensed under
-the MIT License. See LICENSE in the project root for license information. -->
+<!--
+    Copyright (c) Microsoft Corporation. All rights reserved. Licensed under
+    the MIT License. See LICENSE in the project root for license information.
+-->
 <Toolkit:XamlApplication
     x:Class="TerminalApp.App"
     xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
     xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
-    xmlns:local="using:TerminalApp"
-    xmlns:Toolkit="using:Microsoft.Toolkit.Win32.UI.XamlHost"
     xmlns:TA="using:TerminalApp"
+    xmlns:Toolkit="using:Microsoft.Toolkit.Win32.UI.XamlHost"
     xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
+    xmlns:local="using:TerminalApp"
     xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
     mc:Ignorable="d">
-    <!-- If you want to prove this works, then add `RequestedTheme="Light"` to
-    the properties on the XamlApplication -->
+    <!--
+        If you want to prove this works, then add `RequestedTheme="Light"` to
+        the properties on the XamlApplication
+    -->
     <Toolkit:XamlApplication.Resources>
 
         <ResourceDictionary>
             <ResourceDictionary.MergedDictionaries>
-                <!-- Include the MUX Controls resources -->
-                <XamlControlsResources xmlns="using:Microsoft.UI.Xaml.Controls"/>
+                <!--  Include the MUX Controls resources  -->
+                <XamlControlsResources xmlns="using:Microsoft.UI.Xaml.Controls" />
                 <ResourceDictionary>
 
-                    <!-- We're going to apply this style to the root Grid acting
-                    as the tab row, because we need to be able to set its
-                    `Background` property to "{ThemeResource
-                    ApplicationPageBackgroundThemeBrush}" so it will be colored
-                    appropriately for the theme, regardless of what we set the
-                    RequestedTheme to -->
+                    <!--
+                        We're going to apply this style to the root Grid acting
+                        as the tab row, because we need to be able to set its
+                        `Background` property to "{ThemeResource
+                        ApplicationPageBackgroundThemeBrush}" so it will be colored
+                        appropriately for the theme, regardless of what we set the
+                        RequestedTheme to
+                    -->
                     <Style x:Name="BackgroundGridThemeStyle" TargetType="Grid">
                         <Setter Property="Background" Value="{ThemeResource ApplicationPageBackgroundThemeBrush}" />
                     </Style>
 
-                    <!-- We need to manually create the error text brush as a
-                    theme-dependent brush. SystemControlErrorTextForegroundBrush
-                    is unfortunately static. -->
+                    <!--
+                        We need to manually create the error text brush as a
+                        theme-dependent brush. SystemControlErrorTextForegroundBrush
+                        is unfortunately static.
+                    -->
                     <SolidColorBrush x:Name="ErrorTextBrush" Color="{ThemeResource SystemErrorTextColor}" />
 
-                    <!-- Suppress all padding except left around the tabs. The TabView looks far better like this. -->
+                    <!--  Suppress all padding except left around the tabs. The TabView looks far better like this.  -->
                     <Thickness x:Key="TabViewHeaderPadding">8,0,0,0</Thickness>
 
                     <ResourceDictionary.ThemeDictionaries>
                         <ResourceDictionary x:Key="Dark">
-                            <!-- Define resources for Dark mode here -->
+                            <!--  Define resources for Dark mode here  -->
                             <SolidColorBrush x:Key="TabViewBackground" Color="#FF333333" />
                         </ResourceDictionary>
 
                         <ResourceDictionary x:Key="Light">
-                            <!-- Define resources for Light mode here -->
+                            <!--  Define resources for Light mode here  -->
                             <SolidColorBrush x:Key="TabViewBackground" Color="#FFCCCCCC" />
                         </ResourceDictionary>
 

src/cascadia/TerminalApp/CommandPalette.cpp

@@ -117,6 +117,51 @@ namespace winrt::TerminalApp::implementation
         _filteredActionsView().ScrollIntoView(_filteredActionsView().SelectedItem());
     }
 
+   // Method Description:
+   // - Scrolls the focus up or down the list of commands.
+   // Arguments:
+   // - pageDown: if true, we're attempting to move to last visible item in the
+   //   list. Otherwise, we're attempting to move to first visible item.
+   // Return Value:
+   // - <none>
+    void CommandPalette::ScrollDown(const bool pageDown)
+    {
+        const auto container = _filteredActionsView().ContainerFromIndex(0);
+        const auto item = container.try_as<winrt::Windows::UI::Xaml::Controls::ListViewItem>();
+        const auto itemHeight = ::base::saturated_cast<int>(item.ActualHeight());
+        const auto listHeight = ::base::saturated_cast<int>(_filteredActionsView().ActualHeight());
+        const int numVisibleItems = listHeight / itemHeight;
+
+        auto selected = _filteredActionsView().SelectedIndex();
+        const int numItems = ::base::saturated_cast<int>(_filteredActionsView().Items().Size());
+
+        const auto newIndex = ((numItems + selected + (pageDown ? numVisibleItems : -numVisibleItems)) % numItems);
+        _filteredActionsView().SelectedIndex(newIndex);
+        _filteredActionsView().ScrollIntoView(_filteredActionsView().SelectedItem());
+    }
+
+   // Method Description:
+   // - Moves the focus either to top item or end item in the list of commands.
+   // Arguments:
+   // - end: if true, we're attempting to move to last item in the
+   //   list. Otherwise, we're attempting to move to first item.
+   //   Depends on the pageUpDown argument.
+   // Return Value:
+   // - <none>
+    void CommandPalette::GoEnd(const bool end)
+    {
+        const auto lastIndex = ::base::saturated_cast<int>(_filteredActionsView().Items().Size() - 1);
+        if (end)
+        {
+            _filteredActionsView().SelectedIndex(lastIndex);
+        }
+        else
+        {
+            _filteredActionsView().SelectedIndex(0);
+        }
+        _filteredActionsView().ScrollIntoView(_filteredActionsView().SelectedItem());
+    }
+
     // Method Description:
     // - Called when the command selection changes. We'll use this in the tab
     //   switcher to "preview" tabs as the user navigates the list of tabs. To
@@ -193,6 +238,28 @@ namespace winrt::TerminalApp::implementation
             SelectNextItem(true);
             e.Handled(true);
         }
+        else if (key == VirtualKey::PageUp)
+        {
+            // Action Mode: Move focus to the previous item in the list.
+            ScrollDown(false);
+            e.Handled(true);
+        }
+        else if (key == VirtualKey::PageDown)
+        {
+            // Action Mode: Move focus to the previous item in the list.
+            ScrollDown(true);
+            e.Handled(true);
+        }
+        else if (key == VirtualKey::Home)
+        {
+            GoEnd(false);
+            e.Handled(true);
+        }
+        else if (key == VirtualKey::End)
+        {
+            GoEnd(true);
+            e.Handled(true);
+        }
         else if (key == VirtualKey::Enter)
         {
             // Action, TabSwitch or TabSearchMode Mode: Dispatch the action of the selected command.

src/cascadia/TerminalApp/CommandPalette.h

@@ -33,6 +33,10 @@ namespace winrt::TerminalApp::implementation
 
         void SelectNextItem(const bool moveDown);
 
+        void ScrollDown(const bool pageDown);
+
+        void GoEnd(const bool end);
+
         // Tab Switcher
         void EnableTabSwitcherMode(const bool searchMode, const uint32_t startIdx);
         void OnTabsChanged(const Windows::Foundation::IInspectable& s, const Windows::Foundation::Collections::IVectorChangedEventArgs& e);