Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

From orbit, nuke the Telnet connection and all supporting infra. #7840

Merged
4 commits merged into from
Oct 9, 2020

Conversation

DHowett
Copy link
Member

@DHowett DHowett commented Oct 6, 2020

This is not going to be our plan of record for Universal going forward.

This updates the Universal configuration to 1) match non-universal and 2) switch to local applications

@DHowett DHowett requested a review from miniksa October 6, 2020 21:16
@DHowett
Copy link
Member Author

DHowett commented Oct 6, 2020

I also got rid of the "we have two versions of GSL" nonsense :)

Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still can't believe that this works

Comment on lines +109 to +110
{ "command": "toggleFocusMode" },
{ "command": "toggleAlwaysOnTop" },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh man will these work in universal?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, but there's also no point in leaving them off. Many things act weird in WTU, but we should undiverge where we can :)

@DHowett
Copy link
Member Author

DHowett commented Oct 7, 2020

/azp run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@zadjii-msft
Copy link
Member

why is our CI falling to pieces as of late?

@DHowett
Copy link
Member Author

DHowett commented Oct 7, 2020

Excellent question! The memory issue is because I re-enabled parallel builds (sorry :|). This new weird issue? no idea.

@DHowett
Copy link
Member Author

DHowett commented Oct 8, 2020

The x64 build failed for an unrelated reason:

image

@DHowett
Copy link
Member Author

DHowett commented Oct 8, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@DHowett DHowett added the AutoMerge Marked for automatic merge by the bot when requirements are met label Oct 9, 2020
@ghost
Copy link

ghost commented Oct 9, 2020

Hello @DHowett!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@codeofdusk
Copy link
Contributor

I like the branch name!

@DHowett
Copy link
Member Author

DHowett commented Oct 9, 2020

Thanks! 😄

@miniksa
Copy link
Member

miniksa commented Oct 9, 2020

@ghost ghost merged commit d33ca7e into master Oct 9, 2020
@ghost ghost deleted the dev/duhowett/telnope branch October 9, 2020 19:00
skyline75489 pushed a commit to skyline75489/terminal that referenced this pull request Oct 10, 2020
…rosoft#7840)

This is not going to be our plan of record for Universal going forward.

This updates the Universal configuration to 1) match non-universal and 2) switch to local applications
DHowett added a commit that referenced this pull request Oct 19, 2020
This is not going to be our plan of record for Universal going forward.

This updates the Universal configuration to 1) match non-universal and 2) switch to local applications

(cherry picked from commit d33ca7e)
@ghost
Copy link

ghost commented Nov 11, 2020

🎉Windows Terminal v1.4.3141.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented Nov 11, 2020

🎉Windows Terminal Preview v1.5.3142.0 has been released which incorporates this pull request.:tada:

Handy links:

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AutoMerge Marked for automatic merge by the bot when requirements are met
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants