Fix the linter for C++ files #7930
Conversation
zadjii-msft
added
Area-Build
zadjii-msft
added
the
AutoMerge
|
Hello @zadjii-msft! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 6 hours 19 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
@msftbot merge this in like 5 minutes |
|
Hello @zadjii-msft! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
ghost
merged commit 
|
Wow, I saw there was a C++ PR on the linter but it wasn't anything useful for here. Wish I had caught this. That actually sounds like a bug. I'll see if there's already an issue open for it and open one if there is not. |
|
FYI https://github.com/github/super-linter/issues/858 may come bite us. If so, we just need to pin the release until fixed |
|
https://github.com/github/super-linter/issues/825 appears to be the issue and solved by this PR. |
For whatever reason, the super linter seems to think that any file it doesn't recognize is an EDITORCONFIG file. That means all our
cpp,hpp,h,resw,xaml, etc files are going to get linted with different rules than the clang-format ones we already use.This PR disables the EDITORCONFIG linter, and has a minimal change to a cpp file to ensure that it's no longer linted by the action.
See also: