Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase contrast ratio on the CmdPal shortcut text #7937

Merged
merged 1 commit into from
Oct 15, 2020
Merged

Increase contrast ratio on the CmdPal shortcut text #7937

merged 1 commit into from
Oct 15, 2020

Conversation

zadjii-msft
Copy link
Member

@zadjii-msft zadjii-msft commented Oct 15, 2020 •
edited by DHowett
Loading

Summary of the Pull Request

Increase the contrast ratio between the text of the keyboard shortcuts in the cmdpal and their background

Dark mode

image

Light mode

image

References

PR Checklist

@zadjii-msft zadjii-msft added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-User Interface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. Priority-3 A description (P3) labels Oct 15, 2020
@ghost ghost added Impact-Compliance It gotta be this way. Issue-Task It's a feature request, but it doesn't really need a major design. labels Oct 15, 2020
@DHowett
Copy link
Member

DHowett commented Oct 15, 2020

I changed the verb from Resolves to Addresses, because GitHub picked up on it as a synonym for close ;P

@DHowett DHowett merged commit 9d911c0 into master Oct 15, 2020
@DHowett DHowett deleted the dev/migrie/b/7915-cmdpal-contrast branch October 15, 2020 22:49
DHowett pushed a commit that referenced this pull request Oct 19, 2020
@zadjii-msft @DHowett
Increase contrast ratio on the CmdPal shortcut text (#7937)
67e2057 
Related to #7915.

(cherry picked from commit 9d911c0)
@ghost
Copy link

ghost commented Nov 11, 2020

🎉Windows Terminal v1.4.3141.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented Nov 11, 2020

🎉Windows Terminal Preview v1.5.3142.0 has been released which incorporates this pull request.:tada:

Handy links:

@DHowett DHowett mentioned this pull request Jan 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlos-zamora carlos-zamora carlos-zamora approved these changes

@DHowett DHowett DHowett approved these changes

Assignees

@carlos-zamora carlos-zamora

Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Impact-Compliance It gotta be this way. Issue-Bug It either shouldn't be doing this or needs an investigation. Issue-Task It's a feature request, but it doesn't really need a major design. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zadjii-msft @DHowett @carlos-zamora