-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store and expose hidden profiles #8070
Conversation
This comment has been minimized.
This comment has been minimized.
0552641
to
6baa453
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm cool with this.
Make sure that |
Verified! Works like a charm! 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow that was easier than I thought it would be
@msftbot merge this in 1 minute |
Hello @carlos-zamora! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
🎉 Handy links: |
Summary of the Pull Request
This PR replaces
CascadiaSettings::_profiles
with..._allProfiles
: the list of all available profiles in the settings model (i.e. settings.json, dynamic profiles, etc...)_activeProfiles
: the list of all non-hidden profiles (used for the new tab dropdown)References
#8018: maintaining a list of all profiles allows us to serialize hidden profiles
#1564: Settings UI can link to
AllProfiles()
instead ofActiveProfiles()
to expose hidden profilesPR Checklist
hidden
profiles are deleted, not hidden #4139Validation Steps Performed
Deploy and testing succeeded