Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make all nav items top level and remove addprofile #8089

Merged
3 commits merged into from
Oct 30, 2020
Merged

Make all nav items top level and remove addprofile #8089

3 commits merged into from
Oct 30, 2020

Conversation

cinnamon-msft
Copy link
Contributor

Summary of the Pull Request

image

References

PR Checklist

  • Closes #xxx
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Documentation updated. If checked, please file a pull request on our docs repo and link it here: #xxx
  • Schema updated.
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

DHowett
DHowett previously requested changes Oct 29, 2020
View reviewed changes
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as above

@ghost ghost added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Oct 29, 2020
@ghost ghost removed the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Oct 30, 2020
@carlos-zamora carlos-zamora dismissed DHowett’s stale review October 30, 2020 17:25

Chatted with @DHowett about this yesterday. We're gonna try and get all the localization stuff done today. Since his main concern here was localization, I'm dismissing it and merging.

@carlos-zamora carlos-zamora added the AutoMerge Marked for automatic merge by the bot when requirements are met label Oct 30, 2020
@ghost
Copy link

ghost commented Oct 30, 2020

Hello @carlos-zamora!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 6f56738 into feature/settings-ui Oct 30, 2020
@ghost ghost deleted the cinnamon/move-nav-items branch October 30, 2020 17:49
@carlos-zamora carlos-zamora mentioned this pull request Oct 30, 2020
Merged
6 tasks
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miniksa miniksa miniksa approved these changes

@carlos-zamora carlos-zamora carlos-zamora approved these changes

@DHowett DHowett DHowett approved these changes

Assignees
No one assigned
Labels
AutoMerge Marked for automatic merge by the bot when requirements are met
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cinnamon-msft @DHowett @carlos-zamora @miniksa