Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] Display progress in pane #8115

Closed
wants to merge 16 commits into from
Closed

Conversation

PankajBhojwani
Copy link
Contributor

@PankajBhojwani PankajBhojwani commented Oct 30, 2020

Summary of the Pull Request

Currently, a very initial implementation of showing progress in the pane. When we receive the OSC sequence to update the taskbar progress, we also update the pane's progress bar

Bunch of TODOs left:

  • Add a setting to disable this
  • Add settings for size/location/etc of the progress bar
  • Improve the error and paused states (perhaps with a different style?) The current error state is no different from a progress = 0 state and the paused state is barely noticeable compared to a normal state

References

#6700

PR Checklist

  • Closes #xxx
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Documentation updated. If checked, please file a pull request on our docs repo and link it here: #xxx
  • Schema updated.
  • I work here

Validation Steps Performed

Progress bar updates with the appropriate OSC sequences

@PankajBhojwani PankajBhojwani changed the title Display progress in pane [DRAFT] Display progress in pane Oct 30, 2020
@PankajBhojwani PankajBhojwani marked this pull request as draft October 30, 2020 18:35
Base automatically changed from dev/pabhoj/taskbar_progress to main November 18, 2020 22:24
@DHowett DHowett deleted the dev/pabhoj/tab_progress branch February 5, 2021 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant