Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add groupings to profile page #8516

Merged
merged 5 commits into from
Dec 9, 2020

Conversation

cinnamon-msft
Copy link
Contributor

Summary of the Pull Request

To help with organization, I've added headers to group like items together on the profile page.

image

References

PR Checklist

  • Closes #xxx
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Documentation updated. If checked, please file a pull request on our docs repo and link it here: #xxx
  • Schema updated.
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

@carlos-zamora
Copy link
Member

Don't forget, you need 2 approvals now that we're in the process of merging to main. 😊

Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea these are nits. Let's throw them on the project board and be done with it

Comment on lines 145 to 146
<CheckBox x:Uid="Profile_RetroTerminalEffect"
IsChecked="{x:Bind State.Profile.RetroTerminalEffect, Mode=TwoWay}"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a follow-up, maybe we should have the retro effect on the advanced page? I'm thinking about the future world where there's the retro effect or any dang shader you want, that should go in the advanced settings for sure.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funny story about that. Originally, it was gonna be its own grouping. But this would be the only setting in that grouping haha. But yeah, once more cool settings like that go in, we can move stuff around.

src/cascadia/TerminalSettingsEditor/Profiles.xaml Outdated Show resolved Hide resolved
@carlos-zamora carlos-zamora merged commit 93158e7 into feature/settings-ui Dec 9, 2020
@carlos-zamora carlos-zamora deleted the cinnamon/settings-ui-groupings branch December 9, 2020 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants