-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add groupings to profile page #8516
Add groupings to profile page #8516
Conversation
src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw
Outdated
Show resolved
Hide resolved
Don't forget, you need 2 approvals now that we're in the process of merging to main. 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea these are nits. Let's throw them on the project board and be done with it
<CheckBox x:Uid="Profile_RetroTerminalEffect" | ||
IsChecked="{x:Bind State.Profile.RetroTerminalEffect, Mode=TwoWay}"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For a follow-up, maybe we should have the retro effect on the advanced page? I'm thinking about the future world where there's the retro effect or any dang shader you want, that should go in the advanced settings for sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Funny story about that. Originally, it was gonna be its own grouping. But this would be the only setting in that grouping haha. But yeah, once more cool settings like that go in, we can move stuff around.
Summary of the Pull Request
To help with organization, I've added headers to group like items together on the profile page.
References
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed