Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pane refactor: separate pane into LeafPane and ParentPane, and make them winrt types #9024

Closed
wants to merge 74 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
74 commits
Select commit Hold shift + click to select a range
ed00e40
files in place
PankajBhojwani Jan 22, 2021
4a8d4b5
IPane interface
PankajBhojwani Jan 25, 2021
bcf1720
ascribe to IPane
PankajBhojwani Jan 25, 2021
194f849
initial xaml
PankajBhojwani Jan 25, 2021
e622876
more baby steps
PankajBhojwani Jan 26, 2021
504c5c2
most of skeleton in
PankajBhojwani Jan 26, 2021
74087d6
builds I guess
PankajBhojwani Jan 27, 2021
b0959f1
still builds
PankajBhojwani Jan 27, 2021
d7a4c04
sloooowly
PankajBhojwani Jan 27, 2021
f3dc0a2
moving the code
PankajBhojwani Jan 27, 2021
6f5b499
more moving
PankajBhojwani Jan 27, 2021
961f27e
moooooooove
PankajBhojwani Jan 27, 2021
76efe47
more
PankajBhojwani Jan 28, 2021
5f822af
mooooooooooooooooooooooooooove
PankajBhojwani Jan 28, 2021
0c1d736
moooooooo
PankajBhojwani Jan 29, 2021
a4541a3
i am a cow
PankajBhojwani Jan 30, 2021
56d8e6a
moar moving
PankajBhojwani Feb 1, 2021
758064c
border stuff
PankajBhojwani Feb 1, 2021
b21255d
some event handlers
PankajBhojwani Feb 1, 2021
2bcbc45
started changing tab
PankajBhojwani Feb 1, 2021
e5df4d3
more event handling
PankajBhojwani Feb 2, 2021
4728a60
errors
PankajBhojwani Feb 2, 2021
a35c45c
opening/closing panes works now
PankajBhojwani Feb 3, 2021
89db208
animations partly in
PankajBhojwani Feb 3, 2021
5cdd861
maximize/restore
PankajBhojwani Feb 4, 2021
8ac4140
update borders properly
PankajBhojwani Feb 4, 2021
11772a0
okay now the borders update properly
PankajBhojwani Feb 4, 2021
a91427a
spelling
PankajBhojwani Feb 4, 2021
884c3f2
update active pane in terminal tab
PankajBhojwani Feb 4, 2021
f664608
transfer comments
PankajBhojwani Feb 5, 2021
bb66ec8
the old pane did not go gently into that good night
PankajBhojwani Feb 5, 2021
9da2662
don't need this
PankajBhojwani Feb 5, 2021
3eda960
tab listens to every leaf's close
PankajBhojwani Feb 9, 2021
051e0b0
add pane type changed event, remove got split and child closed events
PankajBhojwani Feb 9, 2021
7fdef87
hopefully this is the last border fix
PankajBhojwani Feb 10, 2021
b028a04
update parent's child type changed handler
PankajBhojwani Feb 10, 2021
c6de9d5
small cleanup
PankajBhojwani Feb 10, 2021
3d75680
entrance animation works now
PankajBhojwani Feb 10, 2021
d2208fa
entrance animation seems to work..
PankajBhojwani Feb 11, 2021
856486e
focus transfer is still buggy
PankajBhojwani Feb 11, 2021
3a78622
use nullptr to empty content
PankajBhojwani Feb 11, 2021
a7d506b
remove a todo
PankajBhojwani Feb 12, 2021
486642c
merge main, fix conflicts, readonly in new impl
PankajBhojwani Feb 16, 2021
b945135
delete pane again
PankajBhojwani Feb 16, 2021
730eafe
update some comments
PankajBhojwani Feb 16, 2021
3ecd86f
format
PankajBhojwani Feb 16, 2021
1d37b71
remove 2s
PankajBhojwani Feb 16, 2021
f7c8a9a
address some comments
PankajBhojwani Mar 2, 2021
85f51ad
address more comments
PankajBhojwani Mar 2, 2021
1752f44
borders name
PankajBhojwani Mar 2, 2021
74f600b
abstracts
PankajBhojwani Mar 2, 2021
62131c0
remove unnecessary includes
PankajBhojwani Mar 2, 2021
d8112e9
yet another focus attempt
PankajBhojwani Mar 9, 2021
4254c62
delete most of pane.h
PankajBhojwani Mar 9, 2021
7c57e62
unfocused brush for parent
PankajBhojwani Mar 15, 2021
1335753
remove pane.h
PankajBhojwani Mar 15, 2021
87e1ff0
debug changes
PankajBhojwani Mar 31, 2021
52c406d
switch to grid to solve focus problem
PankajBhojwani Apr 1, 2021
44de0aa
undo debug changes
PankajBhojwani Apr 1, 2021
d7c5e7c
more
PankajBhojwani Apr 1, 2021
840004f
gah
PankajBhojwani Apr 1, 2021
e5d5669
conflict
PankajBhojwani Apr 7, 2021
fab614c
format
PankajBhojwani Apr 8, 2021
a1040b4
fix close event, tab focuses mru pane upon pane close
PankajBhojwani Apr 12, 2021
6026c0e
settings changes
PankajBhojwani Apr 14, 2021
f09e8cb
cleanup old todos
PankajBhojwani Apr 15, 2021
ee6515b
conflict
PankajBhojwani Jun 2, 2021
e2ec41f
connection state changed event changes
PankajBhojwani Jun 2, 2021
f9fc1b0
Merge branch 'main' of https://github.com/microsoft/terminal into dev…
PankajBhojwani Jun 7, 2021
392be7b
delete
PankajBhojwani Jun 7, 2021
ee358fa
remove dictionary
PankajBhojwani Jun 7, 2021
1067d24
spelling
PankajBhojwani Jun 7, 2021
eec8228
Migrate spelling-0.0.19 changes from main
DHowett Jun 7, 2021
e8c04af
Migrate spelling-0.0.21 changes from main
DHowett Jun 7, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions .github/actions/spelling/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
# check-spelling/check-spelling configuration

File | Purpose | Format | Info
-|-|-|-
[allow/*.txt](allow/) | Add words to the dictionary | one word per line (only letters and `'`s allowed) | [allow](https://github.com/check-spelling/check-spelling/wiki/Configuration#allow)
[reject.txt](reject.txt) | Remove words from the dictionary (after allow) | grep pattern matching whole dictionary words | [reject](https://github.com/check-spelling/check-spelling/wiki/Configuration-Examples%3A-reject)
[excludes.txt](excludes.txt) | Files to ignore entirely | perl regular expression | [excludes](https://github.com/check-spelling/check-spelling/wiki/Configuration-Examples%3A-excludes)
[patterns/*.txt](patterns/) | Patterns to ignore from checked lines | perl regular expression (order matters, first match wins) | [patterns](https://github.com/check-spelling/check-spelling/wiki/Configuration-Examples%3A-patterns)
[candidate.patterns](candidate.patterns) | Patterns that might be worth adding to [patterns.txt](patterns.txt) | perl regular expression with optional comment block introductions (all matches will be suggested) | [candidates](https://github.com/check-spelling/check-spelling/wiki/Feature:-Suggest-patterns)
[line_forbidden.patterns](line_forbidden.patterns) | Patterns to flag in checked lines | perl regular expression (order matters, first match wins) | [patterns](https://github.com/check-spelling/check-spelling/wiki/Configuration-Examples%3A-patterns)
[expect/*.txt](expect.txt) | Expected words that aren't in the dictionary | one word per line (sorted, alphabetically) | [expect](https://github.com/check-spelling/check-spelling/wiki/Configuration#expect)
[advice.md](advice.md) | Supplement for GitHub comment when unrecognized words are found | GitHub Markdown | [advice](https://github.com/check-spelling/check-spelling/wiki/Configuration-Examples%3A-advice)

Note: you can replace any of these files with a directory by the same name (minus the suffix)
and then include multiple files inside that directory (with that suffix) to merge multiple files together.
34 changes: 16 additions & 18 deletions .github/actions/spelling/advice.md
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
<!-- markdownlint-disable MD033 MD041 -->
<!-- See https://github.com/check-spelling/check-spelling/wiki/Configuration-Examples%3A-advice --> <!-- markdownlint-disable MD033 MD041 -->
<details>
<summary>
:pencil2: Contributor please read this
</summary>

By default the command suggestion will generate a file named based on your commit. That's generally ok as long as you add the file to your commit. Someone can reorganize it later.

:warning: The command is written for posix shells. You can copy the contents of each `perl` command excluding the outer `'` marks and dropping any `'"`/`"'` quotation mark pairs into a file and then run `perl file.pl` from the root of the repository to run the code. Alternatively, you can manually insert the items...
:warning: The command is written for posix shells. If it doesn't work for you, you can manually _add_ (one word per line) / _remove_ items to `expect.txt` and the `excludes.txt` files.

If the listed items are:

Expand All @@ -20,31 +20,29 @@ See the `README.md` in each directory for more information.

:microscope: You can test your commits **without** *appending* to a PR by creating a new branch with that extra change and pushing it to your fork. The [check-spelling](https://github.com/marketplace/actions/check-spelling) action will run in response to your **push** -- it doesn't require an open pull request. By using such a branch, you can limit the number of typos your peers see you make. :wink:

<details><summary>:clamp: If you see a bunch of garbage</summary>

If it relates to a ...
<details><summary>well-formed pattern</summary>
<details><summary>If the flagged items are :exploding_head: false positives</summary>

See if there's a [pattern](https://github.com/check-spelling/check-spelling/wiki/Configuration-Examples:-patterns) that would match it.
If items relate to a ...
* binary file (or some other file you wouldn't want to check at all).

If not, try writing one and adding it to a `patterns/{file}.txt`.
Please add a file path to the `excludes.txt` file matching the containing file.

Patterns are Perl 5 Regular Expressions - you can [test](
https://www.regexplanet.com/advanced/perl/) yours before committing to verify it will match your lines.
File paths are Perl 5 Regular Expressions - you can [test](
https://www.regexplanet.com/advanced/perl/) yours before committing to verify it will match your files.

Note that patterns can't match multiline strings.
</details>
<details><summary>binary-ish string</summary>
`^` refers to the file's path from the root of the repository, so `^README\.md$` would exclude [README.md](
../tree/HEAD/README.md) (on whichever branch you're using).

Please add a file path to the `excludes.txt` file instead of just accepting the garbage.
* well-formed pattern.

File paths are Perl 5 Regular Expressions - you can [test](
https://www.regexplanet.com/advanced/perl/) yours before committing to verify it will match your files.
If you can write a [pattern](https://github.com/check-spelling/check-spelling/wiki/Configuration-Examples:-patterns) that would match it,
try adding it to the `patterns.txt` file.

`^` refers to the file's path from the root of the repository, so `^README\.md$` would exclude [README.md](
../tree/HEAD/README.md) (on whichever branch you're using).
</details>
Patterns are Perl 5 Regular Expressions - you can [test](
https://www.regexplanet.com/advanced/perl/) yours before committing to verify it will match your lines.

Note that patterns can't match multiline strings.
</details>

</details>
55 changes: 55 additions & 0 deletions .github/actions/spelling/allow/allow.txt
Original file line number Diff line number Diff line change
@@ -1,7 +1,18 @@
admins
allcolors
Apc
apc
breadcrumb
breadcrumbs
bsd
calt
ccmp
changelog
clickable
clig
CMMI
copyable
cybersecurity
dalet
Dcs
dcs
Expand All @@ -11,43 +22,87 @@ downside
downsides
dze
dzhe
EDDB
EDDC
Enum'd
Fitt
formattings
FTCS
ftp
fvar
gantt
gcc
geeksforgeeks
ghe
github
gje
godbolt
hostname
hostnames
https
hyperlink
hyperlinking
hyperlinks
iconify
img
inlined
It'd
kje
libfuzzer
libuv
liga
lje
Llast
llvm
Lmid
locl
lol
lorem
Lorigin
maxed
minimalistic
mkmk
mnt
mru
nje
noreply
ogonek
ok'd
overlined
pipeline
postmodern
ptys
qof
qps
rclt
reimplementation
reserialization
reserialize
reserializes
rlig
runtimes
shcha
slnt
Sos
ssh
timeline
timelines
timestamped
TLDR
tokenizes
tonos
toolset
tshe
ubuntu
uiatextrange
UIs
und
unregister
versioned
vsdevcmd
We'd
wildcards
XBox
YBox
yeru
zhe
Loading