Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show a preview of the control in the SUI #9527
Show a preview of the control in the SUI #9527
Changes from 33 commits
655e277
df21383
8fb913b
4573552
fb498a2
e169044
bab15fa
40b8dab
3884568
ae344fc
69f88aa
4929ac5
24e2f4d
d0d85bd
0ab99f2
db1fd7f
e0a300f
bf90b2e
1a09e83
61ca463
1352f13
fe634d0
33607fe
2f205c1
e8bc850
78d96a6
53ab5f7
0a4b532
40bdb2d
a539f5c
40f353b
540bdf6
1d171d1
64708e4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very clever. we do also remove the cursor when it loses focus, though, too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, the preview control is no longer enabled nor focusable (see Profiles.cpp lines 484-485) - so the cursor just stays on and with this sequence it doesn't blink
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Be sure to test what happens when you resize the window and the TermControl doesn't fit (or resizes). Idk how difficult it would be to add reflow, but I'm guessing we need something here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reflow will be impossible. On resize, the connection should simply clear the terminal and re-print the entire preview text.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason for this is that resize is a destructive operation when content is pushed off the top of the screen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method still needs to be implemented for that right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah it actually doesn't! The connection doesn't need to do anything
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait, no.. on resize, the connection must re-print the entire preview text. Resize with reflow destroys the content that goes off the top of the screen, and the connection needs to clear the screen and put it back. Now, since we never resize the control this isn't going to be a problem... but do keep it in mind.