Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix azuredevops_team - Add members should not fail if the member is already present #1130

Merged
merged 3 commits into from
Aug 26, 2024

Conversation

nilleb
Copy link
Contributor

@nilleb nilleb commented Aug 14, 2024

When adding a member to a group,
If this member is already part of the group,
We should be considering the mode specified on the resource
And NOT fail if the user is already member of the group.

All Submissions:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.
  • I ran lint checks locally prior to submission.
  • Have you checked to ensure there aren't other open PRs for the same update/change?

What about the current behavior has changed?

Issue Number: #1129

Does this introduce a change to go.mod, go.sum or vendor/?

  • Yes
  • No

Does this introduce a breaking change?

  • Yes
  • No

Any relevant logs, error output, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Other information

@nilleb
Copy link
Contributor Author

nilleb commented Aug 14, 2024

@microsoft-github-policy-service agree

@nilleb
Copy link
Contributor Author

nilleb commented Aug 14, 2024

@nilleb please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

@xuzhang3 xuzhang3 changed the title fix: add members should not fail if the member is already present and… Bug fix azuredevops_team_members - Add members should not fail if the member is already present and… Aug 26, 2024
@xuzhang3 xuzhang3 changed the title Bug fix azuredevops_team_members - Add members should not fail if the member is already present and… Bug fix azuredevops_team_members - Add members should not fail if the member is already present Aug 26, 2024
@xuzhang3 xuzhang3 changed the title Bug fix azuredevops_team_members - Add members should not fail if the member is already present Bug fix azuredevops_team - Add members should not fail if the member is already present Aug 26, 2024
@xuzhang3
Copy link
Collaborator

=== RUN   TestAccTeam_DataSource_Basic
--- PASS: TestAccTeam_DataSource_Basic (88.53s)
=== RUN   TestAccTeam_CreateAndUpdate
--- PASS: TestAccTeam_CreateAndUpdate (108.87s)
=== RUN   TestAccTeam_CreateAndUpdateAdministrators
--- PASS: TestAccTeam_CreateAndUpdateAdministrators (153.27s)
=== RUN   TestAccTeam_CreateAndUpdateMembers
--- PASS: TestAccTeam_CreateAndUpdateMembers (160.57s)
PASS
ok      github.com/microsoft/terraform-provider-azuredevops/azuredevops/internal/acceptancetests        517.293s

@xuzhang3
Copy link
Collaborator

@nilleb LGTM

@xuzhang3 xuzhang3 merged commit a0a36eb into microsoft:main Aug 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azuredevops_team_members: error: Failed adding member aad.xyz to team TeamName
2 participants