Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Fix]All service connection - Fix import share service connection not point to the right project #1211

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

xuzhang3
Copy link
Collaborator

@xuzhang3 xuzhang3 commented Nov 1, 2024

All Submissions:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.
  • I ran lint checks locally prior to submission.
  • Have you checked to ensure there aren't other open PRs for the same update/change?

What about the current behavior has changed?

Fixes: #586

Does this introduce a change to go.mod, go.sum or vendor/?

  • Yes
  • No

Does this introduce a breaking change?

  • Yes
  • No

Any relevant logs, error output, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Other information

@xuzhang3
Copy link
Collaborator Author

xuzhang3 commented Nov 1, 2024

=== RUN   TestAccServiceEndpointAws_basic
=== PAUSE TestAccServiceEndpointAws_basic
=== RUN   TestAccServiceEndpointAws_complete
=== PAUSE TestAccServiceEndpointAws_complete
=== RUN   TestAccServiceEndpointAws_update
=== PAUSE TestAccServiceEndpointAws_update
=== RUN   TestAccServiceEndpointAws_requiresImportErrorStep
=== CONT  TestAccServiceEndpointAws_basic
=== CONT  TestAccServiceEndpointAws_update
=== CONT  TestAccServiceEndpointAws_requiresImportErrorStep
=== CONT  TestAccServiceEndpointAws_complete
--- PASS: TestAccServiceEndpointAws_complete (90.53s)
--- PASS: TestAccServiceEndpointAws_basic (318.78s)
--- PASS: TestAccServiceEndpointAws_requiresImportErrorStep (318.93s)
--- PASS: TestAccServiceEndpointAws_update (356.16s)
PASS
ok      github.com/microsoft/terraform-provider-azuredevops/azuredevops/internal/acceptancetests        364.360s

@xuzhang3 xuzhang3 merged commit d201aa1 into microsoft:main Nov 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azuredevops_serviceendpoint_aws does not support 'shared' service connections
1 participant