Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhance] - azuredevops_serviceendpoint_aws - Add nil check and update test case #1239

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

xuzhang3
Copy link
Collaborator

All Submissions:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.
  • I ran lint checks locally prior to submission.
  • Have you checked to ensure there aren't other open PRs for the same update/change?

What about the current behavior has changed?

Update test case and add nil check

Does this introduce a change to go.mod, go.sum or vendor/?

  • Yes
  • No

Does this introduce a breaking change?

  • Yes
  • No

Any relevant logs, error output, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Other information

@xuzhang3
Copy link
Collaborator Author

=== RUN   TestAccServiceEndpointAws_basic
=== PAUSE TestAccServiceEndpointAws_basic
=== RUN   TestAccServiceEndpointAws_complete
=== PAUSE TestAccServiceEndpointAws_complete
=== RUN   TestAccServiceEndpointAws_update
=== PAUSE TestAccServiceEndpointAws_update
=== RUN   TestAccServiceEndpointAws_oidc
=== PAUSE TestAccServiceEndpointAws_oidc
=== RUN   TestAccServiceEndpointAws_requiresImportErrorStep
=== PAUSE TestAccServiceEndpointAws_requiresImportErrorStep
=== CONT  TestAccServiceEndpointAws_basic
=== CONT  TestAccServiceEndpointAws_oidc
=== CONT  TestAccServiceEndpointAws_update
=== CONT  TestAccServiceEndpointAws_requiresImportErrorStep
=== CONT  TestAccServiceEndpointAws_complete
--- PASS: TestAccServiceEndpointAws_basic (167.67s)
--- PASS: TestAccServiceEndpointAws_requiresImportErrorStep (205.00s)
--- PASS: TestAccServiceEndpointAws_update (228.87s)
--- PASS: TestAccServiceEndpointAws_complete (700.02s)
--- PASS: TestAccServiceEndpointAws_oidc (708.76s)
PASS
ok      github.com/microsoft/terraform-provider-azuredevops/azuredevops/internal/acceptancetests        715.875s

@xuzhang3 xuzhang3 merged commit 2823101 into microsoft:main Nov 27, 2024
@xuzhang3 xuzhang3 changed the title [Enhance] - azuredevops_serviceendpoint_aws - Add nil check and test case [Enhance] - azuredevops_serviceendpoint_aws - Add nil check and update test case Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant