Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhance] - azuredevops_serviceendpoint_azurecr - Change serviceprincipalid to forceNew=true #1247

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

xuzhang3
Copy link
Collaborator

@xuzhang3 xuzhang3 commented Dec 4, 2024

All Submissions:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.
  • I ran lint checks locally prior to submission.
  • Have you checked to ensure there aren't other open PRs for the same update/change?

What about the current behavior has changed?

Close: #1214

=== RUN   TestAccServiceEndpointAzureCR_dataSource
=== PAUSE TestAccServiceEndpointAzureCR_dataSource
=== RUN   TestAccServiceEndpointAzureCR_spn_basic
=== PAUSE TestAccServiceEndpointAzureCR_spn_basic
=== RUN   TestAccServiceEndpointAzureCR_spn_update
=== PAUSE TestAccServiceEndpointAzureCR_spn_update
=== CONT  TestAccServiceEndpointAzureCR_dataSource
=== CONT  TestAccServiceEndpointAzureCR_spn_update
=== CONT  TestAccServiceEndpointAzureCR_spn_basic
--- PASS: TestAccServiceEndpointAzureCR_dataSource (85.09s)
--- PASS: TestAccServiceEndpointAzureCR_spn_basic (86.71s)
--- PASS: TestAccServiceEndpointAzureCR_spn_update (90.91s)
PASS
ok      github.com/microsoft/terraform-provider-azuredevops/azuredevops/internal/acceptancetests        98.574s

Does this introduce a change to go.mod, go.sum or vendor/?

  • Yes
  • No

Does this introduce a breaking change?

  • Yes
  • No

Any relevant logs, error output, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Other information

@xuzhang3 xuzhang3 merged commit 634b328 into microsoft:main Dec 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azuredevops_serviceendpoint_azurecr fails to update serviceprincipalid
1 participant