feat: Add azuredevops_group_entitlment

[stanleyz]

This change is based on PR #707, most of the work should be credited to marley-ma.

#707

"

All Submissions:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.
• My code follows the code style of this project.
• I ran lint checks locally prior to submission.
• Have you checked to ensure there aren't other open PRs for the same update/change?

What about the current behavior has changed?

Issue Number:

#700

Issue Number: 700

Does this introduce a change to go.mod, go.sum or vendor/?

• Yes
• No

Does this introduce a breaking change?

• Yes
• No

Any relevant logs, error output, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Other information

[xuzhang3]

@stanleyz A few changes requested, others looks good to me.
Document website/docs/r/group_entitlement.html.markdown need to be documented in azuredevops.erb

[xuzhang3]

Suggested change

	if !uuidRegexp.MatchString(upn) {
	return nil, fmt.Errorf("Only UUID values can used for import [%s]", upn)
	}

[stanleyz]

This is still required, uuid.parse doesn't valid the same as this regex. See the function TestGroupEntitlement_Import_TestInvalidValue in resource_group_entitlement_test.go

[xuzhang3]

The d.id() is from service which we can trust is a valid UUID. If the ID is not a valid UUID, there is a something wrong with the service

[stanleyz]

normally yes, however this function is for importing existing resource, you can't guarantee the users will always have a valid UUID supplied, it's not a big deal but additional check with nice error message always helps.

[xuzhang3]

UUID already check by _, err := uuid.Parse(d.Id()), no need to verify twice

[stanleyz]

cool, updated. That was my impression in the first look, double checked, there was a logic error in the test, not the uuid.Parse. I've updated the test and import function.

[stanleyz]

@stanleyz A few changes requested, others looks good to me. Document website/docs/r/group_entitlement.html.markdown need to be documented in azuredevops.erb

@xuzhang3 I've added the link to the azuredevops.erb, also commented on the ones that haven't been resolved, can you please check? Thanks.

[xuzhang3]

=== RUN   TestAccGroupEntitlement_Create
=== PAUSE TestAccGroupEntitlement_Create
=== RUN   TestAccGroupEntitlement_AAD_Create
=== PAUSE TestAccGroupEntitlement_AAD_Create
=== CONT  TestAccGroupEntitlement_Create
=== CONT  TestAccGroupEntitlement_AAD_Create
--- PASS: TestAccGroupEntitlement_AAD_Create (32.29s)
--- PASS: TestAccGroupEntitlement_Create (32.78s)
PASS
ok      github.com/microsoft/terraform-provider-azuredevops/azuredevops/internal/acceptancetests        38.848s