Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azuredevops_check_required_template support githubenterprise repository type #962

Merged

Conversation

phynot
Copy link

@phynot phynot commented Jan 31, 2024

All Submissions:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.
  • I ran lint checks locally prior to submission.
  • Have you checked to ensure there aren't other open PRs for the same update/change?

What about the current behavior has changed?

Azure DevOps release (11/16/23) added support for GitHub Enterprise for required template checks.

Issue Number:

Does this introduce a change to go.mod, go.sum or vendor/?

  • Yes
  • No

Does this introduce a breaking change?

  • Yes
  • No

Any relevant logs, error output, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Other information

Tested terraform apply with local build, githubenterprise looks ok:

  # azuredevops_check_required_template.required_template["dri_test-githubenterprise-Microservices/Microservices-refs/heads/main-test.yml"] will be created
  + resource "azuredevops_check_required_template" "required_template" {
      + id                   = (known after apply)
      + project_id           = "fadc4d72-3c4a-431e-8510-1ed875db83f2"
      + target_resource_id   = "44c67df1-f2ef-4b6b-b9b5-d132cac74474"
      + target_resource_type = "endpoint"

      + required_template {
          + repository_name = "Microservices/Microservices"
          + repository_ref  = "refs/heads/main"
          + repository_type = "githubenterprise"
          + template_path   = "test.yml"
        }
    }

Plan: 1 to add, 0 to change, 0 to destroy.

azuredevops_check_required_template.required_template["dri_test-githubenterprise-Microservices/Microservices-refs/heads/main-test.yml"]: Creating...
azuredevops_check_required_template.required_template["dri_test-githubenterprise-Microservices/Microservices-refs/heads/main-test.yml"]: Creation complete after 0s [id=2948]

Apply complete! Resources: 1 added, 0 changed, 0 destroyed.
image

@phynot
Copy link
Author

phynot commented Jan 31, 2024

@microsoft-github-policy-service agree company="DocuSign"

@phynot phynot marked this pull request as ready for review January 31, 2024 10:49
@xuzhang3 xuzhang3 merged commit 9f8362b into microsoft:main Feb 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants