Are traits still a concept in MTP?

[thomhurst]

I've had an issue raised, and just wondering if I need to do anything or if it's not a concept in the new platform.

thomhurst/TUnit#1145

[thomhurst]

@Evangelink @nohwnd @MarcoRossignoli wondering if you could help please

[nohwnd]

It is a thing and should remain one, both the category (key, value) and trait (just value), this is how we handle them in vstest bridge:

testfx/src/Platform/Microsoft.Testing.Extensions.VSTestBridge/ObjectModel/ObjectModelConverters.cs

Lines 97 to 108 in d3abcd5

	else if (property.Id == "TestObject.Traits"
	&& getPropertyValue(property) is KeyValuePair<string, string>[] traits && traits.Length > 0)
	{
	#pragma warning disable SA1010 // Opening square brackets should be spaced correctly
	testNodeTraits ??= [];
	#pragma warning restore SA1010 // Opening square brackets should be spaced correctly
	testNodeTraits.AddRange(traits);
	}
	// TPv2 is doing some special handling for MSTest... we should probably do the same.
	// See https://github.com/microsoft/vstest/blob/main/src/Microsoft.TestPlatform.Extensions.TrxLogger/Utility/Converter.cs#L66-L70
	else if (property.Id == "MSTestDiscoverer.TestCategory"

to convert to SerializableNamedKeyValuePairsStringProperty https://grep.app/search?q=SerializableNamedKeyValuePairsStringProperty

[thomhurst]

Thanks, I'll give this a go later!

[thomhurst]

@nohwnd SerializableNamedKeyValuePairsStringProperty is internal. Does it need opening up? Or maybe a traits property makes more sense to abstract away the internals and needing to know a "traits" key for framework writers.