Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CategoryAttribute and PropertyAttribute not registered as a test trait #1145

Closed
samtrion opened this issue Nov 3, 2024 · 6 comments · Fixed by #1181
Closed

CategoryAttribute and PropertyAttribute not registered as a test trait #1145

samtrion opened this issue Nov 3, 2024 · 6 comments · Fixed by #1181

Comments

@samtrion
Copy link

samtrion commented Nov 3, 2024

Unfortunately, the current implementation is such that CategoryAttribute and PropertyAttribute are not registered as traits. This prevents, for example, the filtering of tests within Visual Studio.

@thomhurst
Copy link
Owner

I'm not sure the new testing platform has the concept of traits. I'll check in with them.

@nohwnd
Copy link
Contributor

nohwnd commented Nov 5, 2024

wrong window :D response here: microsoft/testfx#3991 (comment)

@thomhurst
Copy link
Owner

I think I'm a bit blocked on this, the VSTest bridge uses an internal serializable property, so I can't access it 🤔

@thomhurst thomhurst linked a pull request Nov 11, 2024 that will close this issue
@thomhurst
Copy link
Owner

@samtrion Can you try on the latest version please?

@samtrion
Copy link
Author

@samtrion Can you try on the latest version please?

I'll have a look at it in the next few hours. Thanks for the quick solution 👍

@samtrion
Copy link
Author

@thomhurst 👍 Looks good at first glance. I'll take some time over the next few days to have a closer look at custom categories and properties.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants