-
Notifications
You must be signed in to change notification settings - Fork 289
Open
Labels
Area: MTPBelongs to the Microsoft.Testing.Platform core libraryBelongs to the Microsoft.Testing.Platform core libraryNeeds: DesignNeeds research and proposal for how the feature will be implemented.Needs research and proposal for how the feature will be implemented.
Milestone
Description
Summary
Automatic extension registration via hook is limited does not tell the extension into which dll it registers.
This forces mstest to call GetEntryAssembly which is null in native aot.
public static void AddExtensions(ITestApplicationBuilder testApplicationBuilder, string[] arguments) =>
testApplicationBuilder.AddMSTest(() => [Assembly.GetEntryAssembly()!]);Look for a way to provide the hooking binary to the hook, so it can use it in a fashion similar to Assembly.GetEntryAssembly(), but without it being null in native aot.
This is also an api that is used by all extensions so it is possibly hard to change.
Background and Motivation
Proposed Feature
Alternative Designs
Similar issue and the aot reasoning is mentioned in #4312 but providing arbitrary assemblies externall is not a goal of this change. Instead the api should just answer the question:
I am installing as extension into a dll, what is that dll?
Metadata
Metadata
Assignees
Labels
Area: MTPBelongs to the Microsoft.Testing.Platform core libraryBelongs to the Microsoft.Testing.Platform core libraryNeeds: DesignNeeds research and proposal for how the feature will be implemented.Needs research and proposal for how the feature will be implemented.