Today even if classInit wasnt called we used to call class cleanup. f… #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ixing that and adding a test to cover the scenario
| errorMessage = realException.Message; | ||
| } | ||
| else | ||
| if (this.IsClassInitializeExecuted) |
There was a problem hiding this comment.
IsClassInitializeExecuted [](start = 29, length = 25)
why another check needed inside?
jayaranigarg
suggested changes
Feb 19, 2018
| @@ -111,6 +111,18 @@ public void TestClassInfoClassCleanupMethodSetShouldThrowForMultipleClassCleanup | |||
| ActionUtility.ActionShouldThrowExceptionOfType(action, typeof(TypeInspectionException)); | |||
| } | |||
|
|
|||
| [TestMethod] | |||
There was a problem hiding this comment.
This is a negative test case. Can we add a positive test case as well?
smadala
suggested changes
Feb 19, 2018
| /// <summary> | ||
| /// Gets a value indicating whether class cleanup has executed. | ||
| /// </summary> | ||
| public bool IsClassCleanupExecuted { get; private set; } |
| return null; | ||
| } | ||
| catch (Exception exception) | ||
| lock (this.testClassExecuteSyncObject) |
There was a problem hiding this comment.
lock can be removed? All clean ups done in single thread. /cc @AbhitejJohn
| @@ -306,40 +311,52 @@ public string RunClassCleanup() | |||
| return null; | |||
| } | |||
|
|
|||
| lock (this.testClassExecuteSyncObject) | |||
| if (this.IsClassInitializeExecuted) | |||
There was a problem hiding this comment.
Nit: how about this.ClassCleanupMethod == null || this.IsClassInitializeExecuted == false?
jayaranigarg
approved these changes
Feb 20, 2018
Merged
mayankbansal018
added a commit
that referenced
this pull request
Apr 3, 2018
* Fixing Key collision for test run parameters (#328) * Base commit * Adding Unit Test * PR comments * Adding logs for diagnostics * Ignoring Test Temporarily * Removing ignore # Conflicts: # test/UnitTests/MSTest.CoreAdapter.Unit.Tests/Execution/TestExecutionManagerTests.cs * Fixing the copyright in the nuspec files. (#350) * Today even if classInit wasnt called we used to call class cleanup. f… (#372) * Today even if classInit wasnt called we used to call class cleanup. fixing that and adding a test to cover the scenario # Conflicts: # src/Adapter/MSTest.CoreAdapter/Execution/TestClassInfo.cs * [Symbol archiving]Converting Portable pdb to full (#375) * COnverting portable pdbs to full for Symbol archiving * Fixing nuget package path * Test fix * Indent fix * Update Fileversion for adapter and framework dlls (#337) * File version update * Moving to 15.6 * PR comments * More PR comments * Throwing exception only if it is of type TestPlatformFormatException (#332) * Throwing exception only if it is of type TestPlatformFormatException * test * Fail discovery if any exception thrown in IDiscoveryContext.GetTestCaseFilter * Fix masking assembly load faolure error message (#382) # Conflicts: # src/Adapter/MSTest.CoreAdapter/Discovery/AssemblyEnumeratorWrapper.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today even if classInit wasnt called we used to call class cleanup. fixing that and adding a test to cover the scenario
#355