Skip to content

Use ReferenceTrimmer #5009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 96 commits into from
Closed
Changes from all commits
Commits
Show all changes
96 commits
Select commit Hold shift + click to select a range
93a7820
Use ReferenceTrimmer
stan-sz Feb 13, 2025
1b01765
Update Directory.Packages.props
stan-sz Feb 13, 2025
0f971c5
WIP
Evangelink Feb 14, 2025
06335f2
More fixes
Evangelink Feb 14, 2025
2a05828
Fix analyzers project
Evangelink Feb 14, 2025
a8750c5
Update Directory.Packages.props
stan-sz Feb 26, 2025
684d232
[main] Bump dotnet-coverage from 17.14.1 to 17.14.2 (#5149)
dependabot[bot] Feb 27, 2025
4966153
[main] Bump MSTest.Analyzers and Microsoft.NETFramework.ReferenceAsse…
dependabot[bot] Feb 27, 2025
35c8da0
[main] Update dependencies from devdiv/DevDiv/vs-code-coverage, dotne…
dotnet-maestro[bot] Feb 27, 2025
d2b5d9b
[main] Bump Microsoft.NETFramework.ReferenceAssemblies and MSTest.Ana…
dependabot[bot] Feb 28, 2025
cb4d69c
[main] Update dependencies from devdiv/DevDiv/vs-code-coverage (#5159)
dotnet-maestro[bot] Mar 1, 2025
910283c
Fix TestingPlatformSelfRegisteredExtensions to allow empty RootNamesp…
Youssef1313 Mar 3, 2025
8e79748
Update CODEOWNERS (#5166)
nohwnd Mar 3, 2025
a3f4bb5
Use terminal logger for discovery (#4907)
nohwnd Mar 3, 2025
38b68dc
[main] Bump Microsoft.NETFramework.ReferenceAssemblies and MSTest.Ana…
dependabot[bot] Mar 4, 2025
6cec6c9
[main] Update dependencies from devdiv/DevDiv/vs-code-coverage, dotne…
dotnet-maestro[bot] Mar 6, 2025
8abc11f
Localized file check-in by OneLocBuild Task: Build definition ID 1218…
dotnet-bot Mar 4, 2025
a69087a
Localized file check-in by OneLocBuild Task: Build definition ID 1218…
dotnet-bot Mar 6, 2025
38e3521
Improve ExecutionContext propagation (#5156)
Youssef1313 Mar 7, 2025
b310c07
use StringBuilder AppendJoin (#5167)
SimonCropp Mar 7, 2025
29a108f
Update NetCore.Client to latest (#5169)
nohwnd Mar 7, 2025
568459a
Remove dead code in TerminalTestReporter (#5185)
Youssef1313 Mar 7, 2025
2e4e5c9
Fix missing capabilities for MSTest.Analyzers.UnitTests (#5178)
Youssef1313 Mar 8, 2025
2cf0d4e
[main] Update dependencies from dotnet/arcade (#5190)
dotnet-maestro[bot] Mar 8, 2025
3c0246d
Fix possible deadlock when writing to console (#5182)
Youssef1313 Mar 10, 2025
e02bb55
Consider `--results-directory` before configuration
Youssef1313 Mar 10, 2025
6c06821
Fix
Youssef1313 Mar 10, 2025
5842267
Fix tests
Youssef1313 Mar 10, 2025
1c369f4
Fix tests
Youssef1313 Mar 10, 2025
3393eea
Obsolete and cleanup
Youssef1313 Mar 10, 2025
2dc7888
Fix test
Youssef1313 Mar 10, 2025
834334d
[main] Update dependencies from devdiv/DevDiv/vs-code-coverage, dotne…
dotnet-maestro[bot] Mar 11, 2025
625a0e9
Update README.md with MSTest.Sdk information (#5214)
stan-sz Mar 12, 2025
b737237
[main] Update dependencies from dotnet/arcade (#5215)
dotnet-maestro[bot] Mar 12, 2025
0a6d2d4
Ship props/targets of MSTest.TestFramework and MSTest.TestAdapter in …
Youssef1313 Mar 12, 2025
3d6e562
[main] Update dependencies from dotnet/arcade (#5225)
dotnet-maestro[bot] Mar 13, 2025
6bde50c
Update runtimes versions in global.json (#5218)
Youssef1313 Mar 13, 2025
5bb069d
Move logic relevant to core MTP out of MTP.MSBuild (#5217)
Youssef1313 Mar 13, 2025
1564cb5
Fix main build (#5227)
Youssef1313 Mar 13, 2025
824a9da
Consume MTP.MSBuild from source when using internal test framework (#…
Youssef1313 Mar 13, 2025
eeef800
[main] Bump System.Management from 9.0.2 to 9.0.3 (#5231)
dependabot[bot] Mar 14, 2025
f7e6565
[main] Bump Microsoft.Extensions.FileSystemGlobbing from 9.0.2 to 9.0…
dependabot[bot] Mar 14, 2025
7d4e0bd
Try workaround for official builds (#5233)
Youssef1313 Mar 14, 2025
97bda4a
Don't publish Linux packages (#5234)
Youssef1313 Mar 14, 2025
94cf9c4
[main] Bump MSTest.Analyzers and Microsoft.NETFramework.ReferenceAsse…
dependabot[bot] Mar 14, 2025
6100352
Update dogfooded MSTest version (#5237)
Youssef1313 Mar 14, 2025
26baef3
Add assembly name (#5235)
nohwnd Mar 14, 2025
5228039
[main] Update dependencies from devdiv/DevDiv/vs-code-coverage, dotne…
dotnet-maestro[bot] Mar 14, 2025
09faff8
[main] Update dependencies from devdiv/DevDiv/vs-code-coverage, dotne…
dotnet-maestro[bot] Mar 15, 2025
ed2d117
Correct branding as Microsoft.Testing.Platform (#5240)
Youssef1313 Mar 15, 2025
3a84d31
Fix TestFailedException outcome not propagating to TestResult outcome…
Youssef1313 Mar 15, 2025
2d5e838
Remove extra space (#5238)
nohwnd Mar 17, 2025
30a1ef5
[main] Update dependencies from dotnet/arcade (#5243)
dotnet-maestro[bot] Mar 17, 2025
12e4a8c
Add Changelog for 3.8.3 (#5254)
Youssef1313 Mar 17, 2025
710a16b
[main] Bump MSTest.Analyzers and Microsoft.NETFramework.ReferenceAsse…
dependabot[bot] Mar 17, 2025
04a42e5
Uppdate MSTest dependency of public samples (#5256)
Youssef1313 Mar 18, 2025
d6944a2
[main] Update dependencies from devdiv/DevDiv/vs-code-coverage (#5258)
dotnet-maestro[bot] Mar 18, 2025
9032ca7
[main] Bump Microsoft.VisualStudio.Threading.Analyzers and Microsoft.…
dependabot[bot] Mar 18, 2025
1dad7c6
Fix Retry for dotnet test (#5261)
Youssef1313 Mar 18, 2025
5f164c6
Update dogfooded MSTest version (#5262)
Youssef1313 Mar 18, 2025
2a02a63
[main] Update dependencies from devdiv/DevDiv/vs-code-coverage (#5263)
dotnet-maestro[bot] Mar 19, 2025
456d6a8
[main] Update dependencies from devdiv/DevDiv/vs-code-coverage (#5269)
dotnet-maestro[bot] Mar 20, 2025
24b71dc
[main] Bump MSTest.Analyzers and Microsoft.NETFramework.ReferenceAsse…
dependabot[bot] Mar 20, 2025
0a8de19
Add Azure DevOps extension to report errors (#5260)
nohwnd Mar 20, 2025
843799b
Fix stackoverflow in Assert.DoesNotContain (#5275)
Youssef1313 Mar 20, 2025
d2b49fd
Onboard to new dotnet test experience (#5111)
Evangelink Mar 20, 2025
c06bd1a
Fix typo in docs for `StringAssert.That` (#5281)
YoshiRulz Mar 20, 2025
f102098
Add InstanceId to communication with dotnet test (#5279)
mariam-abdulla Mar 20, 2025
0f933f5
[main] Update dependencies from devdiv/DevDiv/vs-code-coverage (#5284)
dotnet-maestro[bot] Mar 21, 2025
797004f
Revert wrong version change (#5286)
Youssef1313 Mar 21, 2025
ec8d1a4
Add instance id to dotnet test protocol (#5287)
mariam-abdulla Mar 21, 2025
58daa84
Use FileAccess.Read when reading testconfig.json file (#5264)
Youssef1313 Mar 21, 2025
939daff
Cleanup no longer needed #if RELEASE for obsoletion (#5290)
Youssef1313 Mar 21, 2025
48aaffe
Fix TypeCache re-calculating info when running in parallel (#5291)
Youssef1313 Mar 21, 2025
6386f8f
[main] Update dependencies from devdiv/DevDiv/vs-code-coverage, dotne…
dotnet-maestro[bot] Mar 23, 2025
61144fe
Localized file check-in by OneLocBuild Task: Build definition ID 1218…
dotnet-bot Mar 23, 2025
067e48c
Fix test property not considering the test class correctly (#5293)
Youssef1313 Mar 23, 2025
d605482
Use new version of .NET SDK and re-enable new dotnet test experience …
Youssef1313 Mar 23, 2025
175c034
Fix typo in TestMethodAttribute documentation (#5300)
bjornhellander Mar 23, 2025
2993bc7
[main] Bump Microsoft.CodeAnalysis.PublicApiAnalyzers and Microsoft.N…
dependabot[bot] Mar 24, 2025
9edaae5
[main] Bump Microsoft.CodeAnalysis.BannedApiAnalyzers and Microsoft.N…
dependabot[bot] Mar 24, 2025
6fc0491
Fix parameterized UI tests for WinUI (#5305)
Youssef1313 Mar 24, 2025
4dc124d
Add analyzer for duplicate data row (#5144)
Youssef1313 Mar 25, 2025
1a9a0b6
[main] Update dependencies from devdiv/DevDiv/vs-code-coverage, dotne…
dotnet-maestro[bot] Mar 25, 2025
9a8d27d
Fix MSTEST0032 false positive with nullability analysis (#5315)
Youssef1313 Mar 25, 2025
872e2dd
Update README.md (#5319)
Youssef1313 Mar 26, 2025
7b44c1d
[main] Update dependencies from devdiv/DevDiv/vs-code-coverage, dotne…
dotnet-maestro[bot] Mar 26, 2025
c4affdc
[main] Update dependencies from devdiv/DevDiv/vs-code-coverage (#5322)
dotnet-maestro[bot] Mar 27, 2025
1b1e52b
Add RetryContext.FirstRunResults (#5314)
Youssef1313 Mar 28, 2025
d45e0ac
VSTestBridge: Add traits as TestMetadataProperty (#5316)
Youssef1313 Mar 28, 2025
bb1017f
[main] Update dependencies from devdiv/DevDiv/vs-code-coverage, dotne…
dotnet-maestro[bot] Mar 28, 2025
7735591
Localized file check-in by OneLocBuild Task: Build definition ID 1218…
dotnet-bot Mar 28, 2025
3e96836
[Source Breaking (only for framework authors)]: Support test artifact…
Youssef1313 Mar 28, 2025
0ba45f9
Merge remote-tracking branch 'upstream/main' into patch-1
stan-sz Apr 8, 2025
0f312a1
Merge branch 'microsoft:main' into patch-1
stan-sz Apr 16, 2025
bc92ee7
Merge remote-tracking branch 'upstream/main' into patch-1
stan-sz Apr 30, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions Directory.Build.props
Original file line number Diff line number Diff line change
@@ -40,12 +40,11 @@

<!-- Versioning -->
<PropertyGroup>
<MSTestEnginePreReleaseVersionLabel>alpha</MSTestEnginePreReleaseVersionLabel>

<!--
This is a early preview package, keep 1.0.0-alpha or similar suffix even in official builds.
-->
<MSTestEngineVersionPrefix>1.0.0</MSTestEngineVersionPrefix>
<MSTestEnginePreReleaseVersionLabel>alpha</MSTestEnginePreReleaseVersionLabel>
</PropertyGroup>

<!-- Pack config -->
@@ -70,6 +69,12 @@
<PolyGuard>true</PolyGuard>
</PropertyGroup>

<!-- Test config -->
<PropertyGroup>
<!-- Set the test runner here and not in test folder so that arcade doesn't force add xunit to any folder of the repo -->
<TestRunnerName>TestingPlatformRunner</TestRunnerName>
</PropertyGroup>

<ItemGroup>
<Using Include="System.Collections" />
<Using Include="System.Collections.Concurrent" />
1 change: 1 addition & 0 deletions Directory.Packages.props
Original file line number Diff line number Diff line change
@@ -37,6 +37,7 @@
<PackageVersion Include="Microsoft.CodeAnalysis.PublicApiAnalyzers" Version="$(MicrosoftCodeAnalysisPublicApiAnalyzersVersion)" />
<PackageVersion Include="Microsoft.VisualStudio.Threading.Analyzers" Version="17.13.61" />
<PackageVersion Include="StyleCop.Analyzers" Version="1.2.0-beta.556" />
<GlobalPackageReference Include="ReferenceTrimmer" Version="3.3.11" />
</ItemGroup>
<ItemGroup Label="Product dependencies">
<PackageVersion Include="Microsoft.ApplicationInsights" Version="2.23.0" />
1 change: 1 addition & 0 deletions TestFx.sln
Original file line number Diff line number Diff line change
@@ -72,6 +72,7 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "IntegrationTests", "Integra
EndProject
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "TestAssets", "TestAssets", "{C9F82701-0E0F-4E61-B05B-AE387E7631F6}"
ProjectSection(SolutionItems) = preProject
test\IntegrationTests\TestAssets\Directory.Build.props = test\IntegrationTests\TestAssets\Directory.Build.props
test\IntegrationTests\TestAssets\Directory.Build.targets = test\IntegrationTests\TestAssets\Directory.Build.targets
EndProjectSection
EndProject
1 change: 0 additions & 1 deletion samples/Playground/Playground.csproj
Original file line number Diff line number Diff line change
@@ -20,7 +20,6 @@
<ProjectReference Include="$(RepoRoot)src\Analyzers\MSTest.Analyzers.CodeFixes\MSTest.Analyzers.CodeFixes.csproj" PrivateAssets="all" ReferenceOutputAssembly="false" OutputItemType="Analyzer" />
<ProjectReference Include="$(RepoRoot)src\Analyzers\MSTest.Analyzers\MSTest.Analyzers.csproj" PrivateAssets="all" ReferenceOutputAssembly="false" OutputItemType="Analyzer" />
<PackageReference Include="StreamJsonRpc" />
<ProjectReference Include="$(RepoRoot)src\Platform\Microsoft.Testing.Extensions.Telemetry\Microsoft.Testing.Extensions.Telemetry.csproj" />
</ItemGroup>

<ItemGroup>
18 changes: 18 additions & 0 deletions src/Adapter/MSTest.TestAdapter/Helpers/FixtureMethodRunner.cs
Original file line number Diff line number Diff line change
@@ -12,6 +12,24 @@ namespace Microsoft.VisualStudio.TestPlatform.MSTest.TestAdapter.Helpers;

internal static class FixtureMethodRunner
{
internal static void RunOnContext(ExecutionContext? executionContext, Action action)
{
if (executionContext is null)
{
action();
}
else
{
// CreateCopy doesn't do anything on .NET Core as ExecutionContexts are immutable.
// But it's important on .NET Framework.
// On .NET Framework, ExecutionContext.Run cannot be called twice with the same ExecutionContext.
// Otherwise, it will throw InvalidOperationException with message:
// Cannot apply a context that has been marshaled across AppDomains, that was not acquired through a Capture operation or that has already been the argument to a Set call.
executionContext = executionContext.CreateCopy();
ExecutionContext.Run(executionContext, static action => ((Action)action!).Invoke(), action);
}
}

internal static TestFailedException? RunWithTimeoutAndCancellation(
Action action, CancellationTokenSource cancellationTokenSource, TimeoutInfo? timeoutInfo, MethodInfo methodInfo,
ExecutionContext? executionContext, string methodCanceledMessageFormat, string methodTimedOutMessageFormat,
3 changes: 2 additions & 1 deletion src/Adapter/MSTest.TestAdapter/MSTest.TestAdapter.csproj
Original file line number Diff line number Diff line change
@@ -54,7 +54,8 @@

<ItemGroup>
<ProjectReference Include="$(RepoRoot)src\Adapter\MSTestAdapter.PlatformServices\MSTestAdapter.PlatformServices.csproj" />
<ProjectReference Include="$(RepoRoot)src\Platform\Microsoft.Testing.Extensions.VSTestBridge\Microsoft.Testing.Extensions.VSTestBridge.csproj" Condition=" '$(TargetFramework)' != '$(UwpMinimum)' " />
<ProjectReference Include="$(RepoRoot)src\Platform\Microsoft.Testing.Extensions.VSTestBridge\Microsoft.Testing.Extensions.VSTestBridge.csproj"
Condition=" '$(TargetFramework)' != '$(UwpMinimum)' AND '$(TargetFramework)' != '$(ModernUwpMinimum)' " />
<ProjectReference Include="$(RepoRoot)src\Analyzers\MSTest.Internal.Analyzers\MSTest.Internal.Analyzers.csproj">
<OutputItemType>Analyzer</OutputItemType>
<ReferenceOutputAssembly>false</ReferenceOutputAssembly>
Original file line number Diff line number Diff line change
@@ -22,8 +22,8 @@
</PropertyGroup>

<ItemGroup>
<ProjectReference Include="..\MSTest.Analyzers.CodeFixes\MSTest.Analyzers.CodeFixes.csproj" />
<ProjectReference Include="..\MSTest.Analyzers\MSTest.Analyzers.csproj" />
<ProjectReference Include="..\MSTest.Analyzers.CodeFixes\MSTest.Analyzers.CodeFixes.csproj" NoWarn="RT0002" />
<ProjectReference Include="..\MSTest.Analyzers\MSTest.Analyzers.csproj" NoWarn="RT0002" />
</ItemGroup>

<ItemGroup>
26 changes: 13 additions & 13 deletions src/Analyzers/MSTest.Analyzers/xlf/Resources.cs.xlf
Original file line number Diff line number Diff line change
@@ -19,7 +19,7 @@ The type declaring these methods should also respect the following rules:
-The class shouldn't be 'static'
-The class should be marked with '[TestClass]' (or a derived attribute)
-the class should not be generic.</source>
<target state="translated">Aby byly metody s označením [AssemblyCleanup] platné, musí se řídit následujícím rozložením:
<target state="translated">Aby byly metody s označením [AssemblyCleanup] platné, musí se řídit následujícím rozložením:
– Nesmí být deklarované pro obecnou třídu.
– Musí být public.
– Musí být static.
@@ -29,7 +29,7 @@ The type declaring these methods should also respect the following rules:
– Nesmí přijímat žádný parametr, nebo musí přijímat jediný parametr typu TestContext.
– Návratový typ musí být void, Task nebo ValueTask.

Typ deklarující tyto metody by měl také respektovat následující pravidla:
Typ deklarující tyto metody by měl také respektovat následující pravidla:
– Typ by měl být třída.
– Třída by měla být public nebo internal (pokud testovací projekt používá atribut [DiscoverInternals]).
– Třída by neměla být static.
@@ -64,7 +64,7 @@ The type declaring these methods should also respect the following rules:
-The class shouldn't be 'static'
-The class should be marked with '[TestClass]' (or a derived attribute)
-the class should not be generic.</source>
<target state="translated">Aby byly metody s označením [AssemblyInitialize] platné, musí se řídit následujícím rozložením:
<target state="translated">Aby byly metody s označením [AssemblyInitialize] platné, musí se řídit následujícím rozložením:
– Nesmí být deklarované pro obecnou třídu.
– Musí být public.
– Musí být static.
@@ -74,7 +74,7 @@ The type declaring these methods should also respect the following rules:
– Musí mít jeden parametr typu TestContext.
– Návratový typ musí být void, Task nebo ValueTask.

Typ deklarující tyto metody by měl také respektovat následující pravidla:
Typ deklarující tyto metody by měl také respektovat následující pravidla:
– Typ by měl být třída.
– Třída by měla být public nebo internal (pokud testovací projekt používá atribut [DiscoverInternals]).
– Třída by neměla být static.
@@ -181,7 +181,7 @@ The type declaring these methods should also respect the following rules:
-The class shouldn't be 'static'
-If the class is 'sealed', it should be marked with '[TestClass]' (or a derived attribute)
-the class should not be generic.</source>
<target state="translated">Aby byly metody s označením [ClassCleanup] platné, musí se řídit následujícím rozložením:
<target state="translated">Aby byly metody s označením [ClassCleanup] platné, musí se řídit následujícím rozložením:
– Nesmí být deklarované pro obecnou třídu bez nastavení režimu InheritanceBehavior.
– Musí být public.
– Musí být static.
@@ -193,7 +193,7 @@ The type declaring these methods should also respect the following rules:
– V případě třídy abstract by měl být zadán parametr atributu InheritanceBehavior.BeforeEachDerivedClass.
– V případě třídy sealed by neměl být zadán parametr atributu InheritanceBehavior.BeforeEachDerivedClass.

Typ deklarující tyto metody by měl také respektovat následující pravidla:
Typ deklarující tyto metody by měl také respektovat následující pravidla:
– Typ by měl být třída.
– Třída by měla být public nebo internal (pokud testovací projekt používá atribut [DiscoverInternals]).
– Třída by neměla být static.
@@ -230,7 +230,7 @@ The type declaring these methods should also respect the following rules:
-The class shouldn't be 'static'
-If the class is 'sealed', it should be marked with '[TestClass]' (or a derived attribute)
-the class should not be generic.</source>
<target state="translated">Aby byly metody s označením [ClassInitialize] platné, musí se řídit následujícím rozložením:
<target state="translated">Aby byly metody s označením [ClassInitialize] platné, musí se řídit následujícím rozložením:
– Nesmí být deklarované pro obecnou třídu bez nastavení režimu InheritanceBehavior.
– Musí být public.
– Musí být static.
@@ -242,7 +242,7 @@ The type declaring these methods should also respect the following rules:
– V případě třídy abstract by měl být zadán parametr atributu InheritanceBehavior.BeforeEachDerivedClass.
– V případě třídy sealed by neměl být zadán parametr atributu InheritanceBehavior.BeforeEachDerivedClass.

Typ deklarující tyto metody by měl také respektovat následující pravidla:
Typ deklarující tyto metody by měl také respektovat následující pravidla:
– Typ by měl být třída.
– Třída by měla být public nebo internal (pokud testovací projekt používá atribut [DiscoverInternals]).
– Třída by neměla být static.
@@ -594,7 +594,7 @@ The type declaring these methods should also respect the following rules:
-The class should be 'public' or 'internal' (if the test project is using the '[DiscoverInternals]' attribute)
-The class shouldn't be 'static'
-If the class is 'sealed', it should be marked with '[TestClass]' (or a derived attribute).</source>
<target state="translated">Aby byly metody s označením [TestCleanup] platné, musí se řídit následujícím rozložením:
<target state="translated">Aby byly metody s označením [TestCleanup] platné, musí se řídit následujícím rozložením:
– Musí být public.
– Nesmí být abstract.
– Nesmí být async void.
@@ -604,7 +604,7 @@ The type declaring these methods should also respect the following rules:
– Nesmí přijímat žádný parametr.
– Návratový typ musí být void, Task nebo ValueTask.

Typ deklarující tyto metody by měl také respektovat následující pravidla:
Typ deklarující tyto metody by měl také respektovat následující pravidla:
– Typ by měl být třída.
– Třída by měla být public nebo internal (pokud testovací projekt používá atribut [DiscoverInternals]).
– Třída by neměla být static.
@@ -653,7 +653,7 @@ The type declaring these methods should also respect the following rules:
-The class should be 'public' or 'internal' (if the test project is using the '[DiscoverInternals]' attribute)
-The class shouldn't be 'static'
-If the class is 'sealed', it should be marked with '[TestClass]' (or a derived attribute).</source>
<target state="translated">Aby byly metody s označením [TestInitialize] platné, musí se řídit následujícím rozložením:
<target state="translated">Aby byly metody s označením [TestInitialize] platné, musí se řídit následujícím rozložením:
– Musí být public.
– Nesmí být abstract.
– Nesmí být async void.
@@ -663,7 +663,7 @@ The type declaring these methods should also respect the following rules:
– Nesmí přijímat žádný parametr.
– Návratový typ musí být void, Task nebo ValueTask.

Typ deklarující tyto metody by měl také respektovat následující pravidla:
Typ deklarující tyto metody by měl také respektovat následující pravidla:
– Typ by měl být třída.
– Třída by měla být public nebo internal (pokud testovací projekt používá atribut [DiscoverInternals]).
– Třída by neměla být static.
@@ -821,4 +821,4 @@ Typ deklarující tyto metody by měl také respektovat následující pravidla:
</trans-unit>
</body>
</file>
</xliff>
</xliff>
15 changes: 10 additions & 5 deletions src/Package/MSTest/MSTest.csproj
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<Project>
<Project>

<!-- SDK top import -->
<Import Project="Sdk.props" Sdk="MSBuild.Sdk.Extras" Condition=" '$(OS)' == 'Windows_NT' " />
@@ -44,10 +44,15 @@
</Target>

<ItemGroup>
<ProjectReference Include="$(RepoRoot)src\Adapter\MSTest.TestAdapter\MSTest.TestAdapter.csproj" />
<ProjectReference Include="$(RepoRoot)src\TestFramework\TestFramework.Extensions\TestFramework.Extensions.csproj" />
<ProjectReference Include="$(RepoRoot)src\Analyzers\MSTest.Analyzers.Package\MSTest.Analyzers.Package.csproj" />
<ProjectReference Include="$(RepoRoot)src\Platform\Microsoft.Testing.Extensions.TrxReport\Microsoft.Testing.Extensions.TrxReport.csproj" Condition=" '$(TargetFramework)' != '$(UwpMinimum)' " />
<ProjectReference Include="$(RepoRoot)src\Adapter\MSTest.TestAdapter\MSTest.TestAdapter.csproj"
NoWarn="RT0002" />
<ProjectReference Include="$(RepoRoot)src\TestFramework\TestFramework.Extensions\TestFramework.Extensions.csproj"
NoWarn="RT0002" />
<ProjectReference Include="$(RepoRoot)src\Analyzers\MSTest.Analyzers.Package\MSTest.Analyzers.Package.csproj"
NoWarn="RT0002" />
<ProjectReference Include="$(RepoRoot)src\Platform\Microsoft.Testing.Extensions.TrxReport\Microsoft.Testing.Extensions.TrxReport.csproj"
Condition=" '$(TargetFramework)' != '$(UwpMinimum)' "
NoWarn="RT0002" />

<!-- CodeCoverage 17.14 doesn't support netcoreapp3.1. -->
<!-- We end up having System.Collections.Immutable 8.0.0 which is not compatible with netcoreapp3.1 -->
Original file line number Diff line number Diff line change
@@ -37,7 +37,6 @@ This package extends Microsoft Testing Platform to provide a crash dump function

<ItemGroup>
<ProjectReference Include="$(RepoRoot)src\Platform\Microsoft.Testing.Platform\Microsoft.Testing.Platform.csproj" />
<ProjectReference Include="$(RepoRoot)src\Platform\Microsoft.Testing.Extensions.TrxReport.Abstractions\Microsoft.Testing.Extensions.TrxReport.Abstractions.csproj" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here. Does this affect the publicly visible dependencies of CrashDump?

</ItemGroup>

<ItemGroup>
Original file line number Diff line number Diff line change
@@ -18,7 +18,7 @@
<ItemGroup>
<ProjectReference Include="$(RepoRoot)src\Platform\Microsoft.Testing.Platform\Microsoft.Testing.Platform.csproj" />
<ProjectReference Include="$(RepoRoot)src\Platform\Microsoft.Testing.Extensions.TrxReport.Abstractions\Microsoft.Testing.Extensions.TrxReport.Abstractions.csproj" />
<ProjectReference Include="$(RepoRoot)src\Platform\Microsoft.Testing.Extensions.Telemetry\Microsoft.Testing.Extensions.Telemetry.csproj" />
<ProjectReference Include="$(RepoRoot)src\Platform\Microsoft.Testing.Extensions.Telemetry\Microsoft.Testing.Extensions.Telemetry.csproj" ReferenceOutputAssembly="false" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this affect the publicly visible dependencies of the VSTestBridge NuGet package?

</ItemGroup>

<!-- NuGet properties -->
Original file line number Diff line number Diff line change
@@ -18,7 +18,8 @@
<ItemGroup>
<ProjectReference Include="$(RepoRoot)\src\Platform\Microsoft.Testing.Platform\Microsoft.Testing.Platform.csproj" CopyToBuildOutput="true" />
<!-- Deps only so we can include it in the lib of the NuGet package -->
<ProjectReference Include="$(RepoRoot)\src\Platform\Microsoft.Testing.Extensions.MSBuild\Microsoft.Testing.Extensions.MSBuild.csproj" PrivateAssets="All" />
<ProjectReference Include="$(RepoRoot)\src\Platform\Microsoft.Testing.Extensions.MSBuild\Microsoft.Testing.Extensions.MSBuild.csproj" PrivateAssets="All"
NoWarn="RT0002" />
</ItemGroup>

<!-- NuGet properties -->
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT license. See LICENSE file in the project root for full license information.

using Microsoft.Testing.Platform.TestHost;

Check failure on line 4 in src/Platform/Microsoft.Testing.Platform/Messages/TestNodeProperties.cs

Azure Pipelines / microsoft.testfx (Build MacOS Debug)

src/Platform/Microsoft.Testing.Platform/Messages/TestNodeProperties.cs#L4

src/Platform/Microsoft.Testing.Platform/Messages/TestNodeProperties.cs(4,1): error IDE0005: (NETCORE_ENGINEERING_TELEMETRY=Build) Using directive is unnecessary. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0005)

Check failure on line 4 in src/Platform/Microsoft.Testing.Platform/Messages/TestNodeProperties.cs

Azure Pipelines / microsoft.testfx (Build MacOS Debug)

src/Platform/Microsoft.Testing.Platform/Messages/TestNodeProperties.cs#L4

src/Platform/Microsoft.Testing.Platform/Messages/TestNodeProperties.cs(4,1): error IDE0005: (NETCORE_ENGINEERING_TELEMETRY=Build) Using directive is unnecessary. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0005)

Check failure on line 4 in src/Platform/Microsoft.Testing.Platform/Messages/TestNodeProperties.cs

Azure Pipelines / microsoft.testfx (Build MacOS Debug)

src/Platform/Microsoft.Testing.Platform/Messages/TestNodeProperties.cs#L4

src/Platform/Microsoft.Testing.Platform/Messages/TestNodeProperties.cs(4,1): error IDE0005: (NETCORE_ENGINEERING_TELEMETRY=Build) Using directive is unnecessary. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0005)

Check failure on line 4 in src/Platform/Microsoft.Testing.Platform/Messages/TestNodeProperties.cs

Azure Pipelines / microsoft.testfx (Build MacOS Debug)

src/Platform/Microsoft.Testing.Platform/Messages/TestNodeProperties.cs#L4

src/Platform/Microsoft.Testing.Platform/Messages/TestNodeProperties.cs(4,1): error IDE0005: (NETCORE_ENGINEERING_TELEMETRY=Build) Using directive is unnecessary. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0005)

Check failure on line 4 in src/Platform/Microsoft.Testing.Platform/Messages/TestNodeProperties.cs

Azure Pipelines / microsoft.testfx (Build MacOS Release)

src/Platform/Microsoft.Testing.Platform/Messages/TestNodeProperties.cs#L4

src/Platform/Microsoft.Testing.Platform/Messages/TestNodeProperties.cs(4,1): error IDE0005: (NETCORE_ENGINEERING_TELEMETRY=Build) Using directive is unnecessary. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0005)

Check failure on line 4 in src/Platform/Microsoft.Testing.Platform/Messages/TestNodeProperties.cs

Azure Pipelines / microsoft.testfx (Build MacOS Release)

src/Platform/Microsoft.Testing.Platform/Messages/TestNodeProperties.cs#L4

src/Platform/Microsoft.Testing.Platform/Messages/TestNodeProperties.cs(4,1): error IDE0005: (NETCORE_ENGINEERING_TELEMETRY=Build) Using directive is unnecessary. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0005)

Check failure on line 4 in src/Platform/Microsoft.Testing.Platform/Messages/TestNodeProperties.cs

Azure Pipelines / microsoft.testfx (Build MacOS Release)

src/Platform/Microsoft.Testing.Platform/Messages/TestNodeProperties.cs#L4

src/Platform/Microsoft.Testing.Platform/Messages/TestNodeProperties.cs(4,1): error IDE0005: (NETCORE_ENGINEERING_TELEMETRY=Build) Using directive is unnecessary. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0005)

Check failure on line 4 in src/Platform/Microsoft.Testing.Platform/Messages/TestNodeProperties.cs

Azure Pipelines / microsoft.testfx (Build MacOS Release)

src/Platform/Microsoft.Testing.Platform/Messages/TestNodeProperties.cs#L4

src/Platform/Microsoft.Testing.Platform/Messages/TestNodeProperties.cs(4,1): error IDE0005: (NETCORE_ENGINEERING_TELEMETRY=Build) Using directive is unnecessary. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0005)

Check failure on line 4 in src/Platform/Microsoft.Testing.Platform/Messages/TestNodeProperties.cs

Azure Pipelines / microsoft.testfx (Build MacOS Release)

src/Platform/Microsoft.Testing.Platform/Messages/TestNodeProperties.cs#L4

src/Platform/Microsoft.Testing.Platform/Messages/TestNodeProperties.cs(4,1): error IDE0005: (NETCORE_ENGINEERING_TELEMETRY=Build) Using directive is unnecessary. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0005)

Check failure on line 4 in src/Platform/Microsoft.Testing.Platform/Messages/TestNodeProperties.cs

Azure Pipelines / microsoft.testfx (Build Linux Release)

src/Platform/Microsoft.Testing.Platform/Messages/TestNodeProperties.cs#L4

src/Platform/Microsoft.Testing.Platform/Messages/TestNodeProperties.cs(4,1): error IDE0005: (NETCORE_ENGINEERING_TELEMETRY=Build) Using directive is unnecessary. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0005)

Check failure on line 4 in src/Platform/Microsoft.Testing.Platform/Messages/TestNodeProperties.cs

Azure Pipelines / microsoft.testfx (Build Linux Release)

src/Platform/Microsoft.Testing.Platform/Messages/TestNodeProperties.cs#L4

src/Platform/Microsoft.Testing.Platform/Messages/TestNodeProperties.cs(4,1): error IDE0005: (NETCORE_ENGINEERING_TELEMETRY=Build) Using directive is unnecessary. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0005)

Check failure on line 4 in src/Platform/Microsoft.Testing.Platform/Messages/TestNodeProperties.cs

Azure Pipelines / microsoft.testfx (Build Linux Release)

src/Platform/Microsoft.Testing.Platform/Messages/TestNodeProperties.cs#L4

src/Platform/Microsoft.Testing.Platform/Messages/TestNodeProperties.cs(4,1): error IDE0005: (NETCORE_ENGINEERING_TELEMETRY=Build) Using directive is unnecessary. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0005)

Check failure on line 4 in src/Platform/Microsoft.Testing.Platform/Messages/TestNodeProperties.cs

Azure Pipelines / microsoft.testfx (Build Linux Release)

src/Platform/Microsoft.Testing.Platform/Messages/TestNodeProperties.cs#L4

src/Platform/Microsoft.Testing.Platform/Messages/TestNodeProperties.cs(4,1): error IDE0005: (NETCORE_ENGINEERING_TELEMETRY=Build) Using directive is unnecessary. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0005)

Check failure on line 4 in src/Platform/Microsoft.Testing.Platform/Messages/TestNodeProperties.cs

Azure Pipelines / microsoft.testfx (Build Linux Debug)

src/Platform/Microsoft.Testing.Platform/Messages/TestNodeProperties.cs#L4

src/Platform/Microsoft.Testing.Platform/Messages/TestNodeProperties.cs(4,1): error IDE0005: (NETCORE_ENGINEERING_TELEMETRY=Build) Using directive is unnecessary. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0005)

Check failure on line 4 in src/Platform/Microsoft.Testing.Platform/Messages/TestNodeProperties.cs

Azure Pipelines / microsoft.testfx (Build Linux Debug)

src/Platform/Microsoft.Testing.Platform/Messages/TestNodeProperties.cs#L4

src/Platform/Microsoft.Testing.Platform/Messages/TestNodeProperties.cs(4,1): error IDE0005: (NETCORE_ENGINEERING_TELEMETRY=Build) Using directive is unnecessary. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0005)

Check failure on line 4 in src/Platform/Microsoft.Testing.Platform/Messages/TestNodeProperties.cs

Azure Pipelines / microsoft.testfx (Build Linux Debug)

src/Platform/Microsoft.Testing.Platform/Messages/TestNodeProperties.cs#L4

src/Platform/Microsoft.Testing.Platform/Messages/TestNodeProperties.cs(4,1): error IDE0005: (NETCORE_ENGINEERING_TELEMETRY=Build) Using directive is unnecessary. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0005)

Check failure on line 4 in src/Platform/Microsoft.Testing.Platform/Messages/TestNodeProperties.cs

Azure Pipelines / microsoft.testfx (Build Linux Debug)

src/Platform/Microsoft.Testing.Platform/Messages/TestNodeProperties.cs#L4

src/Platform/Microsoft.Testing.Platform/Messages/TestNodeProperties.cs(4,1): error IDE0005: (NETCORE_ENGINEERING_TELEMETRY=Build) Using directive is unnecessary. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0005)

Check failure on line 4 in src/Platform/Microsoft.Testing.Platform/Messages/TestNodeProperties.cs

Azure Pipelines / microsoft.testfx (Build Linux Debug)

src/Platform/Microsoft.Testing.Platform/Messages/TestNodeProperties.cs#L4

src/Platform/Microsoft.Testing.Platform/Messages/TestNodeProperties.cs(4,1): error IDE0005: (NETCORE_ENGINEERING_TELEMETRY=Build) Using directive is unnecessary. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0005)

Check failure on line 4 in src/Platform/Microsoft.Testing.Platform/Messages/TestNodeProperties.cs

Azure Pipelines / microsoft.testfx

src/Platform/Microsoft.Testing.Platform/Messages/TestNodeProperties.cs#L4

src/Platform/Microsoft.Testing.Platform/Messages/TestNodeProperties.cs(4,1): error IDE0005: (NETCORE_ENGINEERING_TELEMETRY=Build) Using directive is unnecessary. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0005)

Check failure on line 4 in src/Platform/Microsoft.Testing.Platform/Messages/TestNodeProperties.cs

Azure Pipelines / microsoft.testfx

src/Platform/Microsoft.Testing.Platform/Messages/TestNodeProperties.cs#L4

src/Platform/Microsoft.Testing.Platform/Messages/TestNodeProperties.cs(4,1): error IDE0005: (NETCORE_ENGINEERING_TELEMETRY=Build) Using directive is unnecessary. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0005)

Check failure on line 4 in src/Platform/Microsoft.Testing.Platform/Messages/TestNodeProperties.cs

Azure Pipelines / microsoft.testfx

src/Platform/Microsoft.Testing.Platform/Messages/TestNodeProperties.cs#L4

src/Platform/Microsoft.Testing.Platform/Messages/TestNodeProperties.cs(4,1): error IDE0005: (NETCORE_ENGINEERING_TELEMETRY=Build) Using directive is unnecessary. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0005)

Check failure on line 4 in src/Platform/Microsoft.Testing.Platform/Messages/TestNodeProperties.cs

Azure Pipelines / microsoft.testfx

src/Platform/Microsoft.Testing.Platform/Messages/TestNodeProperties.cs#L4

src/Platform/Microsoft.Testing.Platform/Messages/TestNodeProperties.cs(4,1): error IDE0005: (NETCORE_ENGINEERING_TELEMETRY=Build) Using directive is unnecessary. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0005)

namespace Microsoft.Testing.Platform.Extensions.Messages;

/// <summary>
1 change: 1 addition & 0 deletions test/Directory.Build.targets
Original file line number Diff line number Diff line change
@@ -36,6 +36,7 @@
<ProjectReference Include="$(RepoRoot)src\Platform\Microsoft.Testing.Extensions.CrashDump\Microsoft.Testing.Extensions.CrashDump.csproj" />
<ProjectReference Include="$(RepoRoot)src\Platform\Microsoft.Testing.Extensions.HangDump\Microsoft.Testing.Extensions.HangDump.csproj" />
<ProjectReference Include="$(RepoRoot)src\Platform\Microsoft.Testing.Extensions.Retry\Microsoft.Testing.Extensions.Retry.csproj" />
<ProjectReference Include="$(RepoRoot)src\Platform\Microsoft.Testing.Extensions.Telemetry\Microsoft.Testing.Extensions.Telemetry.csproj" />
<ProjectReference Include="$(RepoRoot)src\Platform\Microsoft.Testing.Extensions.TrxReport\Microsoft.Testing.Extensions.TrxReport.csproj" />
<ProjectReference Include="$(RepoRoot)src\Platform\Microsoft.Testing.Extensions.AzureDevOpsReport\Microsoft.Testing.Extensions.AzureDevOpsReport.csproj" />
<PackageReference Include="Microsoft.Testing.Platform.MSBuild" Condition="'$(UseMSTestFromSource)' == 'true'" />
Loading