Skip to content

Better handling of MSTest.TestAdapter under .NET Standard #5647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 27, 2025
Merged

Better handling of MSTest.TestAdapter under .NET Standard #5647

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b7066ee
Better handling of MSTest.TestAdapter under .NET Standard
Youssef1313 May 27, 2025
6b1a18b
Cleanup copy-pasted code
Youssef1313 May 27, 2025
a3bd440
Update src/Adapter/MSTest.TestAdapter/buildTransitive/common/MSTest.T…
Youssef1313 May 27, 2025
400d987
Update src/Adapter/MSTest.TestAdapter/buildTransitive/common/MSTest.T…
Youssef1313 May 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/Adapter/MSTest.TestAdapter/buildTransitive/common/MSTest.TestAdapter.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,10 @@
<Project>
<Project InitialTargets="NETStandardCompatError_MSTest_TestAdapter">

<Target Name="NETStandardCompatError_MSTest_TestAdapter"
Condition="'$(SuppressTfmSupportBuildWarnings)' == ''">
<Warning Condition="'$(TargetFrameworkIdentifier)' == '.NETStandard'"
Text="MSTest.TestAdapter does not support the target framework '$(TargetFramework)' and has not been tested with it. Test libraries (projects that don't directly run tests) should not reference MSTest.TestAdapter or the MSTest metapackage. Instead, reference only MSTest.TestFramework. To suppress this warning and proceed at your own risk, add &lt;SuppressTfmSupportBuildWarnings&gt;true&lt;/SuppressTfmSupportBuildWarnings&gt; to your project file." />
</Target>

<!-- Handle the coexistence between testing platform and Microsoft.NET.Test.Sdk -->
<PropertyGroup>
Expand Down
2 changes: 2 additions & 0 deletions src/Package/MSTest.Sdk/Sdk/Sdk.props.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@
<Import Project="Sdk.props" Sdk="Microsoft.NET.Sdk" />

<PropertyGroup>
<!-- If the project targets .NET Standard, it's not supposed to be a test application. So, we default to false. -->
<IsTestApplication Condition=" '$(IsTestApplication)' == '' AND '$(TargetFrameworkIdentifier)' == '.NETStandard' ">false</IsTestApplication>
<IsTestApplication Condition=" '$(IsTestApplication)' == '' ">true</IsTestApplication>
</PropertyGroup>

Expand Down
Loading