-
Notifications
You must be signed in to change notification settings - Fork 290
Add TimingProperty with step timing to internal test framework test nodes #6882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Copilot
wants to merge
9
commits into
main
Choose a base branch
from
copilot/add-timingproperty-to-test-nodes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+64
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>
… helper Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add TimingProperty to test nodes in custom framework
Add TimingProperty to internal test framework test nodes
Nov 4, 2025
Copilot finished work on behalf of
Evangelink
November 4, 2025 14:17
Evangelink
reviewed
Nov 4, 2025
test/Utilities/TestFramework.ForTestingMSTest/TestFrameworkEngine.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>
Copilot
AI
changed the title
Add TimingProperty to internal test framework test nodes
Add TimingProperty with step timing to internal test framework test nodes
Nov 4, 2025
Copilot finished work on behalf of
Evangelink
November 4, 2025 15:57
Evangelink
reviewed
Nov 4, 2025
test/Utilities/TestFramework.ForTestingMSTest/TestFrameworkEngine.cs
Outdated
Show resolved
Hide resolved
test/Utilities/TestFramework.ForTestingMSTest/TestFrameworkEngine.cs
Outdated
Show resolved
Hide resolved
Evangelink
reviewed
Nov 5, 2025
test/Utilities/TestFramework.ForTestingMSTest/TestFrameworkEngine.cs
Outdated
Show resolved
Hide resolved
Evangelink
approved these changes
Nov 16, 2025
Youssef1313
reviewed
Nov 16, 2025
| _logger.LogError("Error during test setup", realException); | ||
| DateTimeOffset stepEndTime = DateTimeOffset.UtcNow; | ||
| TestNode errorNode = CloneTestNode(testNode); | ||
| errorNode.Properties.Add(new TimingProperty( |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In case of errors, won't we add the timing property twice? Once here in the catch, and once in the finally from the caller?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

The internal test framework (
TestFramework.ForTestingMSTest) was not reporting timing information for test executions.Changes
ExecuteTestNodeRunAsync: Record start time before test execution, addTimingPropertyin finally block to ensure timing is always reportedStepTimingInfoTryRunSetupMethodAsync,RunTestMethodAsync, andRunTestTeardownAsyncto return tuples containing both the result and step timingCreateTimingPropertyhelper: Centralize timing calculation to reduce duplicationImplementation
All test nodes (passed and error states) now include timing information with detailed breakdown by phase:
This provides both global timing and per-phase timing for performance analysis and test reporting.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.