Fix drain loop test #6897
Merged
Fix drain loop test #6897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Youssef1313
approved these changes
Nov 7, 2025
Evangelink
approved these changes
Nov 7, 2025
Member
|
Merged main to resolve a conflict |
Evangelink
reviewed
Nov 7, 2025
test/UnitTests/Microsoft.Testing.Platform.UnitTests/Messages/AsynchronousMessageBusTests.cs
Outdated
Show resolved
Hide resolved
Evangelink
approved these changes
Nov 7, 2025
Evangelink
approved these changes
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test was using the try catch pattern that we now detect by analyzer. It won't fail the test when there is no exception thrown.
Luckily this is error in the test code and not in the tested code.
There are producers A and B, which produce messages which the other reacts to, so we create a consumer producer loop that never ends.
BUT the producers were using the same Uid, and so we thought that both A and B are the same producer and never put the values to the pipe, so no loop ever happened.
https://github.com/microsoft/testfx/blob/main/src/Platform/Microsoft.Testing.Platform/Messages/ConsumingEnumerableConsumerDataProcessor.cs#L55-L58
Fix #6892