Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle possible null ref in error handler #819

Merged
2 commits merged into from
Apr 16, 2021
Merged

Handle possible null ref in error handler #819

2 commits merged into from
Apr 16, 2021

Conversation

nohwnd
Copy link
Member

@nohwnd nohwnd commented Apr 15, 2021

I have a dump that throws access violation exception in native code and the test run fails with:

An exception occurred while invoking executor 'executor://mstestadapter/v2': Object reference not set to an instance of an object.

I looked through the code and the only way I can get this result is when ex would be null in the handler. Otherwise it fails with different error, either from the asserts in the StackTraceHelper methods or in upstream error handlers.

Haplois
Haplois approved these changes Apr 15, 2021
View reviewed changes
Copy link
Contributor

@Haplois Haplois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a comment.

src/Adapter/MSTest.CoreAdapter/Execution/TestMethodInfo.cs Outdated Show resolved Hide resolved
@ghost
Copy link

ghost commented Apr 16, 2021

Hello @nohwnd!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 179c864 into microsoft:master Apr 16, 2021
HeroMaxPower added a commit to HeroMaxPower/testfx that referenced this pull request Jul 27, 2021
@HeroMaxPower
Squashed commit of the following:
590c5ec 
commit f7de2d4
Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Date:   Wed Jul 21 14:26:59 2021 +0200

    Update dependencies from https://github.com/microsoft/vstest build 20210719-01 (microsoft#925)

    Microsoft.NET.Test.Sdk
     From Version 17.0.0-preview-20210715-01 -> To Version 17.0.0-preview-20210719-01

    Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

commit e8fa622
Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Date:   Wed Jul 21 14:26:32 2021 +0200

    [main] Update dependencies from dotnet/arcade (microsoft#924)

    * Update dependencies from https://github.com/dotnet/arcade build 20210716.1

    Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.SignTool , Microsoft.DotNet.Helix.Sdk
     From Version 6.0.0-beta.21365.11 -> To Version 6.0.0-beta.21366.1

    * Update dependencies from https://github.com/dotnet/arcade build 20210719.3

    Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.SignTool , Microsoft.DotNet.Helix.Sdk
     From Version 6.0.0-beta.21365.11 -> To Version 6.0.0-beta.21369.3

    Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

commit f31b23c
Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Date:   Sat Jul 17 01:25:45 2021 +0200

    Update dependencies from https://github.com/dotnet/arcade build 20210715.11 (microsoft#923)

    Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.SignTool , Microsoft.DotNet.Helix.Sdk
     From Version 6.0.0-beta.21364.3 -> To Version 6.0.0-beta.21365.11

    Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

commit 509d026
Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Date:   Sat Jul 17 01:25:22 2021 +0200

    Update dependencies from https://github.com/microsoft/vstest build 20210715-01 (microsoft#922)

    Microsoft.NET.Test.Sdk
     From Version 17.0.0-preview-20210714-01 -> To Version 17.0.0-preview-20210715-01

    Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

commit 90112ff
Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Date:   Thu Jul 15 14:13:27 2021 +0000

    Update dependencies from https://github.com/dotnet/arcade build 20210714.3 (microsoft#921)

    Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.SignTool , Microsoft.DotNet.Helix.Sdk
     From Version 6.0.0-beta.21363.2 -> To Version 6.0.0-beta.21364.3

    Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

commit a0882c1
Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Date:   Thu Jul 15 14:13:16 2021 +0000

    Update dependencies from https://github.com/microsoft/vstest build 20210714-01 (microsoft#920)

    Microsoft.NET.Test.Sdk
     From Version 17.0.0-preview-20210712-03 -> To Version 17.0.0-preview-20210714-01

    Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

commit b0be7a1
Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Date:   Wed Jul 14 16:42:34 2021 +0200

    Update dependencies from https://github.com/dotnet/arcade build 20210713.2 (microsoft#918)

    Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.SignTool , Microsoft.DotNet.Helix.Sdk
     From Version 6.0.0-beta.21357.3 -> To Version 6.0.0-beta.21363.2

    Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

commit 797c799
Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Date:   Tue Jul 13 20:35:03 2021 +0200

    Update dependencies from https://github.com/microsoft/vstest build 20210712-03 (microsoft#916)

    Microsoft.NET.Test.Sdk
     From Version 17.0.0-preview-20210710-01 -> To Version 17.0.0-preview-20210712-03

    Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

commit 5a432c9
Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Date:   Sun Jul 11 13:08:17 2021 +0000

    Update dependencies from https://github.com/microsoft/vstest build 20210710-01 (microsoft#914)

    [main] Update dependencies from microsoft/vstest

commit 4382f3a
Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Date:   Sat Jul 10 01:58:40 2021 +0200

    Update dependencies from https://github.com/microsoft/vstest build 20210708-01 (microsoft#911)

    Microsoft.NET.Test.Sdk
     From Version 17.0.0-preview-20210705-01 -> To Version 17.0.0-preview-20210708-01

    Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

commit ef4c809
Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Date:   Sat Jul 10 01:58:16 2021 +0200

    Update dependencies from https://github.com/dotnet/arcade build 20210707.3 (microsoft#912)

    Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.SignTool , Microsoft.DotNet.Helix.Sdk
     From Version 6.0.0-beta.21355.2 -> To Version 6.0.0-beta.21357.3

    Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

commit 3ce8458
Author: jvrooyen <28042104+jvrooyen@users.noreply.github.com>
Date:   Thu Jul 8 14:34:49 2021 +0200

    Fix DateTime looses significant digits in DynamicData (microsoft#875) (microsoft#907)

commit 86845cf
Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Date:   Tue Jul 6 15:00:11 2021 +0200

    Update dependencies from https://github.com/dotnet/arcade build 20210705.2 (microsoft#904)

    Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.SignTool , Microsoft.DotNet.Helix.Sdk
     From Version 6.0.0-beta.21351.2 -> To Version 6.0.0-beta.21355.2

    Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

commit c6ba660
Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Date:   Tue Jul 6 12:38:29 2021 +0000

    Update dependencies from https://github.com/microsoft/vstest build 20210629-04 (microsoft#898)

    Microsoft.NET.Test.Sdk
     From Version 17.0.0-preview-20210629-03 -> To Version 17.0.0-preview-20210629-04

    Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

commit 8babc08
Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Date:   Mon Jul 5 08:09:12 2021 +0000

    [main] Update dependencies from dotnet/arcade (microsoft#900)

    * Update dependencies from https://github.com/dotnet/arcade build 20210630.2

    Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.SignTool , Microsoft.DotNet.Helix.Sdk
     From Version 6.0.0-beta.21329.8 -> To Version 6.0.0-beta.21330.2

    * Update dependencies from https://github.com/dotnet/arcade build 20210701.2

    Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.SignTool , Microsoft.DotNet.Helix.Sdk
     From Version 6.0.0-beta.21329.8 -> To Version 6.0.0-beta.21351.2

    Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

commit bb2161a
Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Date:   Wed Jun 30 15:28:14 2021 +0200

    Update dependencies from https://github.com/dotnet/arcade build 20210629.8 (microsoft#899)

    Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.SignTool , Microsoft.DotNet.Helix.Sdk
     From Version 6.0.0-beta.21328.2 -> To Version 6.0.0-beta.21329.8

    Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

commit f017fa2
Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Date:   Tue Jun 29 19:57:50 2021 +0000

    Update dependencies from https://github.com/dotnet/arcade build 20210628.2 (microsoft#897)

    Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.SignTool , Microsoft.DotNet.Helix.Sdk
     From Version 6.0.0-beta.21324.3 -> To Version 6.0.0-beta.21328.2

    Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

commit 463f5b6
Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Date:   Tue Jun 29 19:59:55 2021 +0200

    Update dependencies from https://github.com/microsoft/vstest build 20210629-03 (microsoft#896)

    Microsoft.NET.Test.Sdk
     From Version 17.0.0-preview-20210628-03 -> To Version 17.0.0-preview-20210629-03

    Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

commit 17fee3c
Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Date:   Mon Jun 28 14:40:45 2021 +0200

    Update dependencies from https://github.com/microsoft/vstest build 20210628-03 (microsoft#894)

    Microsoft.NET.Test.Sdk
     From Version 17.0.0-preview-20210627-02 -> To Version 17.0.0-preview-20210628-03

    Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

commit 1fc6719
Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Date:   Mon Jun 28 11:49:59 2021 +0200

    Update dependencies from https://github.com/microsoft/vstest build 20210627-02 (microsoft#893)

    Microsoft.NET.Test.Sdk
     From Version 17.0.0-preview-20210624-09 -> To Version 17.0.0-preview-20210627-02

    Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

commit 50c322c
Author: odalet <odalet@users.noreply.github.com>
Date:   Sun Jun 27 00:38:02 2021 +0200

    Fixes microsoft#799 by testing logged messages against "null or whitespace" instead of "null or empty" (microsoft#892)

    Co-authored-by: Olivier DALET <olivier.dalet@addupsolutions.com>

commit 2d0f311
Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Date:   Fri Jun 25 12:46:10 2021 +0000

    Update dependencies from https://github.com/dotnet/arcade build 20210624.3 (microsoft#891)

    Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.SignTool , Microsoft.DotNet.Helix.Sdk
     From Version 6.0.0-beta.21323.1 -> To Version 6.0.0-beta.21324.3

    Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

commit 10e47b5
Author: Medeni Baykal <433724+Haplois@users.noreply.github.com>
Date:   Fri Jun 25 13:19:36 2021 +0200

    Added missing framework references for WinUI (microsoft#890)

     * Added missing framework references
     * Updated license headers on PowerShell files
     * Included a script to install required Windows SDK

commit aad795f
Author: Morten Nielsen <1378165+dotMorten@users.noreply.github.com>
Date:   Thu Jun 24 14:12:31 2021 -0700

    Upgraded winui to 0.8.0 (microsoft#888)

    The dispatcher has moved to a new namespace

commit 6e699eb
Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Date:   Thu Jun 24 14:54:46 2021 +0000

    Update dependencies from https://github.com/microsoft/vstest build 20210624-09 (microsoft#885)

    Microsoft.NET.Test.Sdk
     From Version 17.0.0-preview-20210623-08 -> To Version 17.0.0-preview-20210624-09

    Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

commit a9d1e1c
Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Date:   Thu Jun 24 16:43:41 2021 +0200

    Update dependencies from https://github.com/dotnet/arcade build 20210623.1 (microsoft#886)

    Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.SignTool , Microsoft.DotNet.Helix.Sdk
     From Version 6.0.0-beta.21321.2 -> To Version 6.0.0-beta.21323.1

    Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

commit 6a09407
Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Date:   Wed Jun 23 12:54:35 2021 +0000

    Update dependencies from https://github.com/dotnet/arcade build 20210621.2 (microsoft#884)

    Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.SignTool , Microsoft.DotNet.Helix.Sdk
     From Version 6.0.0-beta.21321.1 -> To Version 6.0.0-beta.21321.2

    Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

commit ad61572
Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Date:   Wed Jun 23 12:51:42 2021 +0000

    Update dependencies from https://github.com/microsoft/vstest build 20210623-08 (microsoft#883)

    Microsoft.NET.Test.Sdk
     From Version 17.0.0-preview-20210520-02 -> To Version 17.0.0-preview-20210623-08

    Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

commit 5fa4866
Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Date:   Tue Jun 22 22:32:54 2021 +0000

    Update dependencies from https://github.com/dotnet/arcade build 20210621.1 (microsoft#882)

    [main] Update dependencies from dotnet/arcade

commit b5ecab6
Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Date:   Sun Jun 20 22:52:19 2021 +0200

    Update dependencies from https://github.com/dotnet/arcade build 20210619.2 (microsoft#881)

    Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.SignTool , Microsoft.DotNet.Helix.Sdk
     From Version 6.0.0-beta.21318.2 -> To Version 6.0.0-beta.21319.2

    Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

commit a392596
Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Date:   Sat Jun 19 15:43:21 2021 +0200

    Update dependencies from https://github.com/dotnet/arcade build 20210618.2 (microsoft#880)

    Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.SignTool , Microsoft.DotNet.Helix.Sdk
     From Version 6.0.0-beta.21317.1 -> To Version 6.0.0-beta.21318.2

    Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

commit 53a7597
Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Date:   Fri Jun 18 15:10:42 2021 +0200

    Update dependencies from https://github.com/dotnet/arcade build 20210617.1 (microsoft#879)

    Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.SignTool , Microsoft.DotNet.Helix.Sdk
     From Version 6.0.0-beta.21316.3 -> To Version 6.0.0-beta.21317.1

    Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

commit fe6babd
Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Date:   Thu Jun 17 22:58:33 2021 +0000

    Update dependencies from https://github.com/dotnet/arcade build 20210616.3 (microsoft#878)

    [main] Update dependencies from dotnet/arcade

commit 96ad498
Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Date:   Tue Jun 15 14:52:47 2021 +0200

    Update dependencies from https://github.com/dotnet/arcade build 20210614.1 (microsoft#876)

    Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.SignTool , Microsoft.DotNet.Helix.Sdk
     From Version 6.0.0-beta.21311.3 -> To Version 6.0.0-beta.21314.1

    Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

commit e2fbeab
Author: Sanan Yuzbashiyev <Sanan07@users.noreply.github.com>
Date:   Mon Jun 14 01:11:51 2021 +0200

    Adding contribution note (microsoft#873)

    Clarified contribution guidelines, and added extra notices.

    Co-authored-by: Medeni Baykal <433724+Haplois@users.noreply.github.com>

commit 807d6c9
Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Date:   Mon Jun 14 01:01:07 2021 +0200

    Update dependencies from https://github.com/dotnet/arcade build 20210611.3 (microsoft#874)

    Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.SignTool , Microsoft.DotNet.Helix.Sdk
     From Version 6.0.0-beta.21304.1 -> To Version 6.0.0-beta.21311.3

    Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
    Co-authored-by: Medeni Baykal <433724+Haplois@users.noreply.github.com>

commit 59cd5ae
Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Date:   Sat Jun 5 22:35:16 2021 +0200

    Update dependencies from https://github.com/dotnet/arcade build 20210604.1 (microsoft#865)

    Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.SignTool , Microsoft.DotNet.Helix.Sdk
     From Version 6.0.0-beta.21303.2 -> To Version 6.0.0-beta.21304.1

    Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

commit 25e984e
Author: Medeni Baykal <433724+Haplois@users.noreply.github.com>
Date:   Sat Jun 5 03:12:39 2021 +0200

    Fixed a bug in `ITestDataSource` data deserialization (microsoft#864)

     - Fixed a bug in `ITestDataSource` data deserialization when trying to deserialize a type outside of current assembly. This should fix the last item in microsoft#844.
     - Added extra tests cases for `ITestDataSource`, we're now testing almost all cases we can think of.

commit 5d4bb67
Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Date:   Fri Jun 4 15:20:45 2021 +0200

    Update dependencies from https://github.com/dotnet/arcade build 20210603.2 (microsoft#862)

    Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.SignTool , Microsoft.DotNet.Helix.Sdk
     From Version 6.0.0-beta.21302.1 -> To Version 6.0.0-beta.21303.2

    Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

commit 640372c
Author: Medeni Baykal <433724+Haplois@users.noreply.github.com>
Date:   Fri Jun 4 02:44:22 2021 +0200

    Fixed DataSource deserialization. (microsoft#859)

commit f6731ef
Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Date:   Thu Jun 3 14:59:38 2021 +0200

    Update dependencies from https://github.com/dotnet/arcade build 20210602.1 (microsoft#858)

    Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.SignTool , Microsoft.DotNet.Helix.Sdk
     From Version 6.0.0-beta.21281.1 -> To Version 6.0.0-beta.21302.1

    Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

commit 39a52b3
Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Date:   Tue Jun 1 14:29:39 2021 +0000

    Update dependencies from https://github.com/dotnet/arcade build 20210531.1 (microsoft#853)

    [main] Update dependencies from dotnet/arcade

commit 57d2d00
Author: Medeni Baykal <433724+Haplois@users.noreply.github.com>
Date:   Mon May 31 13:04:02 2021 +0200

    Fixed a serialization issue with DataRows. (microsoft#847)

commit 1c62432
Author: Medeni Baykal <433724+Haplois@users.noreply.github.com>
Date:   Mon May 31 09:04:37 2021 +0200

    Replaced license file with an expression. (microsoft#846)

    - Replaced LICENSE files in NuGet packages with a license expression, and added a licenseUrl.

commit eaa3242
Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Date:   Sun May 30 12:56:40 2021 +0000

    Update dependencies from https://github.com/dotnet/arcade build 20210528.1 (microsoft#845)

    [main] Update dependencies from dotnet/arcade

commit 93a72f5
Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Date:   Fri May 28 17:56:15 2021 +0000

    Update dependencies from https://github.com/dotnet/arcade build 20210527.1 (microsoft#841)

    [main] Update dependencies from dotnet/arcade

commit 6b705ed
Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Date:   Thu May 27 15:48:51 2021 +0200

    Update dependencies from https://github.com/dotnet/arcade build 20210526.5 (microsoft#840)

    Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.SignTool , Microsoft.DotNet.Helix.Sdk
     From Version 6.0.0-beta.21275.5 -> To Version 6.0.0-beta.21276.5

    Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
    Co-authored-by: Medeni Baykal <433724+Haplois@users.noreply.github.com>

commit 365f05d
Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Date:   Wed May 26 12:53:09 2021 +0000

    Update dependencies from https://github.com/dotnet/arcade build 20210525.5 (microsoft#836)

    [main] Update dependencies from dotnet/arcade

commit e18a292
Author: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Date:   Tue May 25 19:46:44 2021 +0000

    Update dependencies from https://github.com/dotnet/arcade build 20210524.6 (microsoft#835)

    [main] Update dependencies from dotnet/arcade

commit 43f5000
Author: Medeni Baykal <433724+Haplois@users.noreply.github.com>
Date:   Tue May 25 19:29:45 2021 +0200

    Rename Nuget.config to NuGet.config (microsoft#833)

commit b5c0790
Author: Medeni Baykal <433724+Haplois@users.noreply.github.com>
Date:   Mon May 24 12:09:42 2021 +0200

    Arcade files added (microsoft#832)

    * Added Arcade files.

commit 9e62a25
Author: Jakub Jareš <me@jakubjares.com>
Date:   Thu May 20 11:07:27 2021 +0200

    Rename to main (microsoft#828)

    * Rename to main

    * main file

commit 19acefa
Author: Medeni Baykal <433724+Haplois@users.noreply.github.com>
Date:   Wed May 19 10:22:28 2021 +0200

    Updated MicrosoftNetTestSdkVersion to 16.10.0-release-20210429-01 (microsoft#831)

commit fe3ba4f
Author: Medeni Baykal <433724+Haplois@users.noreply.github.com>
Date:   Tue May 18 02:57:26 2021 +0200

    Refactored projects to use PackageReference. (microsoft#830)

commit 0b95a26
Author: Medeni Baykal <433724+Haplois@users.noreply.github.com>
Date:   Thu May 13 09:20:32 2021 +0200

    Bumped `Newtonsoft.Json` version on WinUI. (microsoft#827)

commit f68fd34
Author: Medeni Baykal <433724+Haplois@users.noreply.github.com>
Date:   Thu May 13 09:20:09 2021 +0200

    Reverting an unintended breaking-change. (microsoft#826)

    Reverting an unintended breaking change in reflection.

    Thank you, @azchohfi, for reporting it; this makes microsoft#824 unnecessary.

commit 30aaca1
Author: Alexandre Zollinger Chohfi <alzollin@microsoft.com>
Date:   Wed Apr 28 15:22:54 2021 -0700

    Small fix for full file path on WinUI (microsoft#823)

commit 2e35bad
Author: Alexandre Zollinger Chohfi <alzollin@microsoft.com>
Date:   Wed Apr 28 12:43:44 2021 -0700

    Added WinUITestSourceHost (microsoft#822)

    Small fix that was preventing tests from running from VS TestExplorer.

commit faf5270
Author: Medeni Baykal <433724+Haplois@users.noreply.github.com>
Date:   Thu Apr 22 01:04:11 2021 +0200

    Moved ITestDataSource discovery to test discovery. (microsoft#794)

    * Moved `ITestDataSource` discovery to test discovery.
    * Hierarchies added into `TestCase`.
    * Id generation moved to AdapterUtilities package.

commit 94c3110
Author: Pavel Horak <22235234+pavelhorak@users.noreply.github.com>
Date:   Mon Apr 19 10:06:54 2021 +0200

    Open Source Code of Conduct update Update (microsoft#816)

commit 179c864
Author: Jakub Jareš <me@jakubjares.com>
Date:   Fri Apr 16 10:44:44 2021 +0200

    Handle possible null ref in error handler (microsoft#819)

    I have a dump that throws access violation exception in native code and the test run fails with:

    `An exception occurred while invoking executor 'executor://mstestadapter/v2': Object reference not set to an instance of an object.`

    I looked through the code and the only way I can get this result is when ex would be null in the handler. Otherwise it fails with different error, either from the asserts in the `StackTraceHelper` methods or in upstream error handlers.

commit e0289e8
Author: Test Platform Bot <79333716+testplatform-bot@users.noreply.github.com>
Date:   Wed Apr 14 10:27:27 2021 +0200

    Localized file check-in by OneLocBuild Task (microsoft#818)

commit 3956a4d
Author: csigs <csigs@users.noreply.github.com>
Date:   Tue Apr 13 10:03:38 2021 -0700

    LEGO: Pull request from lego/hb_63a2d317-b544-477f-9d48-4250bdd255f0_20210413165102761 to master (microsoft#817)

    LEGO: Pull request from lego/hb_63a2d317-b544-477f-9d48-4250bdd255f0_20210413165102761 to master with localized lcls

commit f7b5a40
Author: Test Platform Bot <79333716+testplatform-bot@users.noreply.github.com>
Date:   Tue Apr 13 09:03:29 2021 +0200

    Localized file check-in by OneLocBuild Task (microsoft#815)

commit 072c5ad
Author: csigs <csigs@users.noreply.github.com>
Date:   Mon Apr 12 09:54:48 2021 -0700

    LEGO: Pull request from lego/hb_63a2d317-b544-477f-9d48-4250bdd255f0_20210412164646888 to master (microsoft#814)

    LEGO: Pull request from lego/hb_63a2d317-b544-477f-9d48-4250bdd255f0_20210412164646888 to master with localized lcls

commit d5ee30b
Author: Alexandre Zollinger Chohfi <alzollin@microsoft.com>
Date:   Mon Apr 12 01:58:24 2021 -0700

    Added WinUI TestAdapter. (microsoft#813)

commit 4c980dd
Author: Maximilian Chaplin <chaplin_max@hotmail.com>
Date:   Thu Apr 8 11:59:49 2021 +0200

    Code cleanup with analysers. (microsoft#807)

    Doing some code cleanup with some static analyzers.

    IDE0016 Null check can be simplified
    IDE0018 Variable declaration can be inlined

commit 348e322
Author: Test Platform Bot <79333716+testplatform-bot@users.noreply.github.com>
Date:   Wed Apr 7 15:23:29 2021 +0200

    Localized file check-in by OneLocBuild Task (microsoft#811)

commit f579469
Author: Maximilian Chaplin <chaplin_max@hotmail.com>
Date:   Tue Apr 6 11:34:04 2021 +0200

    Added AreEqual and AreNotEqual tests (microsoft#809)
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Haplois Haplois Haplois approved these changes

Assignees
No one assigned
Labels
auto-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nohwnd @Haplois