Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ChesapeakeCVPR: use NLCD mapping/cmap #1264

Closed
adamjstewart opened this issue Apr 18, 2023 · 1 comment · Fixed by #1690
Closed

ChesapeakeCVPR: use NLCD mapping/cmap #1264

adamjstewart opened this issue Apr 18, 2023 · 1 comment · Fixed by #1690
Assignees
@calebrob6
Labels
datasets Geospatial or benchmark datasets good first issue A good issue for a new contributor to work on

Comments

@adamjstewart
Copy link
Collaborator

Summary

We recently added a new NLCD dataset. Instead of duplicating the class mapping and cmap in ChesapeakeCVPR, we should use them from the NLCD dataset.

Rationale

Code duplication is bad.

Implementation

from .nlcd import NLCD

cmap = NLCD.cmap

Alternatives

Only reason to not duplicate them is in case we add Alaska to NLCD, which contains classes that don't exist in ChesapeakeCVPR. This doesn't affect cmap, but may affect the class mapping if we want to minimize the number of predicted classes.

Additional information

No response
@adamjstewart adamjstewart added the datasets Geospatial or benchmark datasets label Apr 18, 2023
@adamjstewart
Copy link
Collaborator Author

@calebrob6 are you able to work on this?

@calebrob6 calebrob6 added the good first issue A good issue for a new contributor to work on label Sep 29, 2023
@alhridoy alhridoy mentioned this issue Oct 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@calebrob6 calebrob6

Labels
datasets Geospatial or benchmark datasets good first issue A good issue for a new contributor to work on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updated ChesapeakeCVPR to use NLCD colormap alhridoy/torchgeo
2 participants
@calebrob6 @adamjstewart