Updated ChesapeakeCVPR to use NLCD colormap

[alhridoy]

Fixes #1264

This PR updates the ChesapeakeCVPR class in torchgeo/datasets/chesapeake.py to use the colormap from the NLCD dataset.

Changes include:

• Set self.cmap to NLCD.cmap in the __init__ method of the ChesapeakeCVPR class.
• Defined a property _nlcd_cmap that returns self.cmap.

[alhridoy]

@microsoft-github-policy-service agree

@microsoft-github-policy-service agree

[calebrob6]

I like this change @alhridoy, thanks for the contribution! Let me know if you want help with the linters / mypy / etc.

[alhridoy]

Hi @adamjstewart @calebrob6 I've made the changes as per your suggestions. I've removed the _nlcd_cmap property and replaced all its references with self.cmap. I've also set self.cmap to NLCD.cmap in the __init__ method and removed the block of code that was creating nlcd_colors and _nlcd_cmap. Would you check and give me feedbacks.

[adamjstewart]

Ping @alhridoy

[adamjstewart]

There are now no changes lol.

[alhridoy]

There are now no changes lol.

Hi @adamjstewart,

I've made the changes as per your suggestions and committed them. Could you please check and confirm if everything is in order now? Thanks for your guidance and patience.

[adamjstewart]

Still need to do this:

You can now delete nlcd_cmap at the top of this class, it's no longer used.

[alhridoy]

Still need to do this:

You can now delete nlcd_cmap at the top of this class, it's no longer used.

Regarding your suggestion to remove the nlcd_cmap attribute from the Chesapeake class, I noticed that it's being used in the ChesapeakeCVPR class for creating a colormap for the "nlcd" layer. Could you please confirm if the removal is intended for the ChesapeakeCVPR class instead? Thanks for your guidance.

You can now delete nlcd_cmap at the top of this class, it's no longer used.

[adamjstewart]

Yes, for ChesapeakeCVPR. The Chesapeake class doesn't include NLCD data.

[alhridoy]

Some checks were not successful

11 successful, 8 cancelled, and 2 failing checks

After removing the nlcd_cmap I've noticed that some of the checks are failing for my recent commit, specifically the pytest checks. I've looked into the details but I'm having trouble understanding why these tests are failing. Could you please help me understand what might be causing these failures, and how I can fix them?

[adamjstewart]

Seems like an intermittent issue, restarting the test solved it.

[alhridoy]

Seems like an intermittent issue, restarting the test solved it.

Thank you for your patient and guidance throughout the PR. I am happy to contribute.

[adamjstewart]

Thanks for contributing! Hopefully the first of many 😄