Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change documentation theme #2006

Open
adamjstewart opened this issue Apr 17, 2024 · 6 comments
Open

Change documentation theme #2006

adamjstewart opened this issue Apr 17, 2024 · 6 comments
Labels
documentation Improvements or additions to documentation good first issue A good issue for a new contributor to work on

Comments

@adamjstewart
Copy link
Collaborator

Issue

We've been using pytorch-sphinx-theme since the start of the project, but it contains a number of known issues and is barely maintained. We should consider switching to a modern theme with fewer bugs and better support.

Fix

I was originally planning on using trojanzoo-sphinx-theme but it looks like this is also unmaintained now. I don't think I have the skills or expertise to maintain my own fork of either. We should look into popular themes and choose one that looks cool. Can people propose themes and link to examples on this issue?

@adamjstewart adamjstewart added the documentation Improvements or additions to documentation label Apr 17, 2024
@adamjstewart adamjstewart mentioned this issue Apr 17, 2024
20 tasks
@adamjstewart adamjstewart added the good first issue A good issue for a new contributor to work on label Apr 17, 2024
@adamjstewart
Copy link
Collaborator Author

PyTorch Lightning uses a fork of pytorch-sphinx-theme called lightning-sphinx-theme. However, this fork seems to have some of the same problems (no PyPI releases).

@Thakor-Yashpal
Copy link

Can I address this issue?

@adamjstewart
Copy link
Collaborator Author

Sure! You should probably start by proposing a few themes that don't look too different from our current theme or are popular in ML. Once we narrow it down, you can open a few example PRs that change the theme and we can see what they look like.

@Thakor-Yashpal
Copy link

I've been exploring Sphinx themes, and I think the Sphinx-Rtd theme (the Read the Docs fork) might be a good fit for us.

It's familiar, has more customization options, and is still actively maintained.

Would you be open to trying it out? I can set up a test project and show you how it looks in our documentation.

Let me know your thoughts!

@adamjstewart
Copy link
Collaborator Author

Sphinx-rtd-theme is a bit generic and isn't widely used by the PyTorch community. I'm not opposed, but I'm hoping to find something a little fancier. Is there anything else closer to our current theme?

@Thakor-Yashpal
Copy link

Thakor-Yashpal commented Nov 15, 2024

Thanks for the suggestions! I'm leaning towards Furo (with careful customization) or Material for Sphinx. I think Furo's design is a good starting point, and I'm confident I can make it match the PyTorch theme's overall feel. I'll start working on customizing Furo, and if I run into any challenges, I'll definitely come back to you for more advice.

Thakor-Yashpal added a commit to Thakor-Yashpal/torchgeo that referenced this issue Nov 15, 2024
Fixes microsoft#2006

This pull request updates the documentation theme from pytorch-sphinx-theme to Furo in the conf.py file. Furo provides a more modern and customizable look for the documentation.
Thakor-Yashpal added a commit to Thakor-Yashpal/torchgeo that referenced this issue Nov 15, 2024
This pull request updates the documentation theme from pytorch-sphinx-theme to Furo in the conf.py file. Furo provides a more modern and customizable look for the documentation.
Thakor-Yashpal added a commit to Thakor-Yashpal/torchgeo that referenced this issue Nov 18, 2024
Thakor-Yashpal added a commit to Thakor-Yashpal/torchgeo that referenced this issue Nov 19, 2024
Thakor-Yashpal added a commit to Thakor-Yashpal/torchgeo that referenced this issue Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue A good issue for a new contributor to work on
Projects
None yet
Development

No branches or pull requests

2 participants