Fix broken URLs #1125
Merged
Fix broken URLs #1125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
datasets
adamjstewart
commented
Feb 18, 2023
| @@ -19,7 +19,7 @@ | |||
| "source": [ | |||
| "# PyTorch Lightning Trainers\n", | |||
| "\n", | |||
| "In this tutorial, we demonstrate TorchGeo trainers to train and test a model. Specifically, we use the [Tropical Cyclone dataset](https://torchgeo.readthedocs.io/en/latest/api/datasets.html#tropical-cyclone-wind-estimation-competition) and train models to predict cyclone wind speed given imagery of the cyclone. \n", | |||
There was a problem hiding this comment.
Dataset was renamed and link broke
| * `Class Descriptions | ||
| <https://chesapeakeconservancy.org/wp-content/uploads/2020/03/LC_Class_Descriptions.pdf>`_ | ||
| * `Accuracy Assessment | ||
| <https://chesapeakeconservancy.org/wp-content/uploads/2017/01/Chesapeake_Conservancy_Accuracy_Assessment_Methodology.pdf>`_ |
There was a problem hiding this comment.
Some of these links are broken. Most of these docs are linked on the main dataset page, so I don't think we need to explicitly reference them.
| @@ -35,7 +35,7 @@ class EnviroAtlas(GeoDataset): | |||
| This dataset was organized to accompany the 2022 paper, `"Resolving label | |||
| uncertainty with implicit generative models" | |||
| <https://openreview.net/forum?id=AEa_UepnMDX>`_. More details can be found at | |||
| https://github.com/estherrolf/qr_for_landcover. | |||
| https://github.com/estherrolf/implicit-posterior. | |||
There was a problem hiding this comment.
Many of these are repo renames. The old URL still works and redirects to the correct page, but figured we should update them anyway.
| "https://raw.githubusercontent.com/chaozhong2010/VHR-10_dataset_coco/" | ||
| "master/NWPU%20VHR-10_dataset_coco/annotations.json" | ||
| ), | ||
| "url": "https://raw.githubusercontent.com/chaozhong2010/VHR-10_dataset_coco/ce0ba0f5f6a0737031f1cbe05e785ddd5ef05bd7/NWPU%20VHR-10_dataset_coco/annotations.json", # noqa: E501 |
There was a problem hiding this comment.
We should never download files from the master branch, they may change or move to a different location. Instead, we should use permalinks when available.
adamjstewart
force-pushed
the
docs/fix-urls
branch
from
1cdf988 to
90d54c0
Compare
calebrob6
previously approved these changes
Feb 23, 2023
calebrob6
force-pushed
the
docs/fix-urls
branch
from
09f221b to
e844e15
Compare
|
Tests aren't going to pass until the notebook tests are passing. But that test isn't required, this PR can be merged whenever. |
calebrob6
approved these changes
Feb 26, 2023
calebrob6
pushed a commit
that referenced
this pull request
Apr 10, 2023
* Fix broken URLs * Flake8 fix * Don't change Chesapeake URL
yichiac
pushed a commit
to yichiac/torchgeo
that referenced
this pull request
Apr 29, 2023
* Fix broken URLs * Flake8 fix * Don't change Chesapeake URL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TIL you can run:
and Sphinx will parse and check all external links in your docs and warn you which links are broken. Unfortunately there are too many false positives to make this a CI test, but this may be something we want to check before each release.