RasterDataset: fix band indexing bug #1135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
datasets
adamjstewart
changed the title
adamjstewart
changed the title
|
Nice catch! I think |
ashnair1
approved these changes
Feb 23, 2023
calebrob6
pushed a commit
that referenced
this pull request
Apr 10, 2023
* Fix Landsat non-SR band specification * Fix variable reference * Fix test when no all_bands * Fail during init instead * Store variable * all_bands -> default_bands * Simplify logic * fix mypy * Make default_bands required
yichiac
pushed a commit
to yichiac/torchgeo
that referenced
this pull request
Apr 29, 2023
* Fix Landsat non-SR band specification * Fix variable reference * Fix test when no all_bands * Fail during init instead * Store variable * all_bands -> default_bands * Simplify logic * fix mypy * Make default_bands required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes multiple bugs related to band indexing in RasterDataset:
all_bandsdoes not actually contain all bands (e.g., Landsat)all_bandsis not defined andseparate_filesis TrueThe fix was simple. We don't need to compute
band_indexesunlessseparate_filesis False.Confirmed that the tests I added fail without this fix, so this bug shouldn't pop back up in the next release.
Should we rename Landsat's
all_bandstodefault_bands? In #504 we added support for all Level-1 and Level-2 products and decided not to list every possible band name because there are way too many and I can't easily confirm what they were all the way back to Landsat 1.This bug was introduced in #687, apologies for not catching this during review.
Fixes #1134 @TolgaAktas