-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ETCI2021 Dataset #119
Add ETCI2021 Dataset #119
Conversation
Just that split
Prob (1, h w) |
I refactored the filenames, urls, md5s, and directories into a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good, just had a few minor comments.
Co-authored-by: Adam J. Stewart <ajstewart426@gmail.com>
Looks like there are conflicts preventing this from being rebased and merged. Personally I never use merge commits for this very reason. I always rebase manually to resolve merge conflicts. For now I'll squash and merge. |
if os.path.exists(os.path.join(self.root, "__MACOSX")): | ||
shutil.rmtree(os.path.join(self.root, "__MACOSX")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@isaaccorley is this strictly needed? It's currently not covered by our unit tests and I'm wondering if we can just remove it.
* add dataset to docs * add sample test data * add dataset unit tests * add etci2021 dataset * updated tests * updated dataset to download only desired split file * removed flood mask from file list for test set and other formatting * Update torchgeo/datasets/etci2021.py Co-authored-by: Adam J. Stewart <ajstewart426@gmail.com> * fixed doc formatting Co-authored-by: Adam J. Stewart <ajstewart426@gmail.com>
torchgeo.datasets.ETCI2021
from the ETCI 2021 Flood Detection Challengetests/datasets/test_etci2021.py
tests/data/etci2021/
Questions:
(2, h, w)
. However, the test set flood masks were never released so the water mask is loaded(h, w)
. Does this seem right or should I load add the additional dimension(1, h, w)
for consistency?Closes #118