Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deps: make omegaconf/tensorboard optional #1214

Merged
merged 4 commits into from
Apr 5, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ jobs:
- name: Install pip dependencies
if: steps.cache.outputs.cache-hit != 'true'
run: |
pip install .[docs,tests] planetary_computer pystac pytest-rerunfailures tensorboard
pip install .[docs,tests] planetary_computer pystac pytest-rerunfailures
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest of these are things that we could subsume into [tests], but they're also dependencies that I would like to remove in the future, and I don't think they're worth tracking.

pip list
- name: Run notebook checks
run: pytest --nbmake --durations=10 --reruns=10 docs/tutorials
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/tutorials.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
- name: Install pip dependencies
if: steps.cache.outputs.cache-hit != 'true'
run: |
pip install .[docs,tests] planetary_computer pystac pytest-rerunfailures tensorboard
pip install .[docs,tests] planetary_computer pystac pytest-rerunfailures
pip list
- name: Run notebook checks
run: pytest --nbmake --durations=10 --reruns=10 docs/tutorials
Expand Down
1 change: 1 addition & 0 deletions environment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ dependencies:
- segmentation-models-pytorch>=0.2
- setuptools>=42
- sphinx>=4,<6
- tensorboard>=2.9.1
- timm>=0.4.12
- torchmetrics>=0.10
- zipfile-deflate64>=0.2
3 changes: 2 additions & 1 deletion requirements/min-reqs.old
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ kornia==0.6.5
lightning==1.8.0
matplotlib==3.3.0
numpy==1.17.3
omegaconf==2.1.0
pillow==6.2.1
pyproj==2.4.1
rasterio==1.1.1
Expand Down Expand Up @@ -49,5 +48,7 @@ pyupgrade==2.4.0
# tests
mypy==0.900
nbmake==1.3.3
omegaconf==2.1.0
pytest==6.1.2
pytest-cov==2.4.0
tensorboard==2.9.1
3 changes: 1 addition & 2 deletions requirements/required.txt
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,9 @@ setuptools==67.6.0
einops==0.6.0
fiona==1.9.2
kornia==0.6.11
lightning[extra]==2.0.1
lightning==2.0.1
matplotlib==3.7.1
numpy==1.24.2
omegaconf==2.3.0
pillow==9.5.0
pyproj==3.5.0
rasterio==1.3.6
Expand Down
2 changes: 2 additions & 0 deletions requirements/tests.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# tests
mypy==1.1.1
nbmake==1.4.1
omegaconf==2.3.0
pytest==7.2.2
pytest-cov==4.0.0
tensorboard==2.12.1
8 changes: 5 additions & 3 deletions setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -31,13 +31,11 @@ install_requires =
# kornia 0.6.5+ required due to change in kornia.augmentation API
kornia>=0.6.5,<0.7
# lightning 1.8+ is first release
lightning[extra]>=1.8,<2
lightning>=1.8,<2
# matplotlib 3.3+ required for (H, W, 1) image support in plt.imshow
matplotlib>=3.3,<4
# numpy 1.17.3+ required by Python 3.8 wheels
numpy>=1.17.3,<2
# omegaconf 2.1+ required for to_object method
omegaconf>=2.1,<3
# pillow 6.2.1+ required for Python 3.8 wheels
pillow>=6.2.1,<10
# pyproj 2.4.1+ required for Python 3.8 wheels
Expand Down Expand Up @@ -123,10 +121,14 @@ tests =
mypy>=0.900,<2
# nbmake 1.3.3+ required for variable mocking
nbmake>=1.3.3,<2
# omegaconf 2.1+ required for to_object method
omegaconf>=2.1,<3
# pytest 6.1.2+ required by nbmake
pytest>=6.1.2,<8
# pytest-cov 2.4+ required for pytest --cov flags
pytest-cov>=2.4,<5
# tensorboard 2.9.1+ required by lightning
tensorboard>=2.9.1,<3
all =
torchgeo[datasets,docs,style,tests]

Expand Down