-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add National Land Cover Database (NLCD) dataset #1244
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Plot looks great! Also need to add to docs.
Missing test coverage for some lines: https://app.codecov.io/gh/microsoft/torchgeo/pull/1244/blob/torchgeo/datasets/nlcd.py |
not sure why it is not working, I thought the following test would cover it but doesn't:
|
What if you add an additional test that includes years that don't exist locally and need to be "downloaded"? |
found my mistake, and tested again with downloading the real data from scratch and retrieving samples. |
* working nlcd dataset version * citation and correct ordinal color map * add unit tests * requested changes * fix docs * unnecessary space * typos and for loop label conversion * suggested plot changes * use ListedColormap * return fig statement * docs about background class * forgot print * run pyupgrade * found my bug
This PR adds the NLCD dataset, with selective download and using masks for desired years.
Dataset format:
.img
fileDataset features:
Example:
Note:
If the year selection scheme is approved, I would open another PR to change CDL accordingly, so that users don't have to download data for all years.