-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SSL4EO Landsat Downstream Dataset/module CDL, NLCD #1338
SSL4EO Landsat Downstream Dataset/module CDL, NLCD #1338
Conversation
""" | ||
super().__init__(SSL4EOLBenchmark, batch_size, num_workers, **kwargs) | ||
|
||
self.train_aug = AugmentationSequential( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you use the same aug for all splits, you can just set self.aug
instead. However, we might want different augs for train to improve performance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I wrote them out because I thought it remains to be discussed whether we have additional training augs.
) | ||
exists.append(bool(glob.glob(mask_pathname, recursive=True))) | ||
if all(exists): | ||
return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's put a blank line between sections
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant between the return statement and the comment below
plt_cmap = ListedColormap( | ||
np.stack( | ||
[np.array(val) / 255 for val in self.cmaps[self.mask_product].values()], | ||
axis=0, | ||
) | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot to say this during the CDL review, but don't we also need to map this to 134 classes before plotting? Should have asked you to add an example plot for CDL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah sorry, now I do get what you mean. Yeah you are right.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In NLCD the cmap is already done with the ordinal values. I can fix it in CDL in another PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could nitpick for days but I think it's good enough now. Would rather merge it soon so people can start benchmarking. Feel free to merge if you also think it's good enough or address the remaining comments and I'll review again.
This PR adds datasets and module for downstream evaluation of SSL methods.
Sensors:
Masks:
This is a
NonGeoDataset
relying on datasets to be created with the help of #1336.Example CDL TM-TOA: