-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Satlas pretrained Swin Transformer v2 models #1358
Conversation
Will review after deadline |
is the |
No it's not. The layers are named differently unfortunately. |
Wonder if I can map them to each other. |
If it's not too hard, that would be useful since it would let us use it in our trainers. Wonder if we could add some kind of logic to support both timm and torchvision in our trainers... |
It is hard unfortunately. |
I have no idea why the figure plotting in |
Turns out the decrease in test coverage is actually very important! If you remove the try-except from ObjectDetectionTask, you'll find that there is a bug in our implementation:
These were being masked by our try-except. The code works fine for torchvision 0.13 but breaks for any newer version. We didn't notice this because the combined coverage didn't change. From what I can tell, this has always been broken... |
Can you try to fix that in a separate PR so we can backport it to 0.5.2? Or one of us can do it, just let me know if you're busy. |
I'll push a PR here shortly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can merge as soon as coverage issue is fixed.
Adds Swin Transformer v2 Base pretrained models from the Satlas dataset