SSL4EO-L: add download support #1424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
datasets
adamjstewart
commented
Jun 17, 2023
adamjstewart
commented
Jun 17, 2023
| with open(path, "wb") as f: | ||
| for suffix in self.checksums[self.split]: | ||
| with open(path + suffix, "rb") as g: | ||
| while chunk := g.read(chunk_size): |
There was a problem hiding this comment.
This is my first time using assignment expressions, such a neat feature!
|
This looks good to me as long as you check that it works with the real dataset |
|
Yep, I checked |
calebrob6
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preliminary download support for SSL4EO-L. Still need to test to make sure it works on the real dataset.