Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move SKIPPD to HF and add forecast task #1548

Merged
merged 5 commits into from
Sep 24, 2023
Merged

Move SKIPPD to HF and add forecast task #1548

merged 5 commits into from
Sep 24, 2023

Conversation

nilsleh
Copy link
Collaborator

@nilsleh nilsleh commented Sep 5, 2023 •
edited
Loading

The paper of this dataset describes two tasks:

  • nowcast: which is predicting the current power output given a single image
  • forecast: predict the power output given a concatenated series of images

I used their script to generate the forecast version of this dataset and put both on HF for easier and faster download.

Edit:

Example Plot "Nowcast":

Example Plot "Forecast":

@github-actions github-actions bot added datasets Geospatial or benchmark datasets testing Continuous integration testing labels Sep 5, 2023
@adamjstewart adamjstewart added this to the 0.5.0 milestone Sep 7, 2023
adamjstewart
adamjstewart reviewed Sep 7, 2023
View reviewed changes
Copy link
Collaborator

@adamjstewart adamjstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add example plots for both tasks so I can confirm that the plotting updates are good?

torchgeo/datasets/skippd.py Outdated Show resolved Hide resolved
torchgeo/datasets/skippd.py Outdated Show resolved Hide resolved
torchgeo/datasets/skippd.py Outdated Show resolved Hide resolved
torchgeo/datasets/skippd.py Outdated Show resolved Hide resolved
adamjstewart
adamjstewart previously approved these changes Sep 24, 2023
View reviewed changes
Copy link
Collaborator

@adamjstewart adamjstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last typo fix and this should be good to merge!

torchgeo/datasets/skippd.py Outdated Show resolved Hide resolved
@adamjstewart adamjstewart merged commit 242fa90 into microsoft:main Sep 24, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamjstewart adamjstewart adamjstewart approved these changes

Assignees
No one assigned
Labels
datasets Geospatial or benchmark datasets testing Continuous integration testing
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nilsleh @adamjstewart